From owner-cvs-sys Tue Aug 8 10:27:06 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id KAA06612 for cvs-sys-outgoing; Tue, 8 Aug 1995 10:27:06 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id KAA06606 ; Tue, 8 Aug 1995 10:27:01 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id KAA04241; Tue, 8 Aug 1995 10:26:17 -0700 From: "Rodney W. Grimes" Message-Id: <199508081726.KAA04241@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: jkh@time.cdrom.com (Jordan K. Hubbard) Date: Tue, 8 Aug 1995 10:26:16 -0700 (PDT) Cc: bde@zeta.org.au, CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, dyson@freefall.cdrom.com In-Reply-To: <19405.807885268@time.cdrom.com> from "Jordan K. Hubbard" at Aug 8, 95 05:34:28 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 942 Sender: cvs-sys-owner@freebsd.org Precedence: bulk > > > Actually it isn't really OK to simply substitute M_NOWAIT with M_WAITOK. > > If one of the malloc()s in scioctl() sleeps, then another process may > > run and use the half-allocated resources. If one of the malloc()s in in > > scioctl() or scopen() sleeps, then another process may run and repeat the > > ioctl and (at best) allocate the resources twice. > > Argh. Perhaps I was too hasty. If John decides to rearchitect this, > I'll pull it out of 2.1 We really should let bits sit in -current for a week or two before pulling them into the 2.1 branch, per David's mail on this subject about how to get stuff into the branch, I though that was the plan. This allows time for these types of problems to surface so we don't have to go back things out of the -stable branch. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD