From owner-freebsd-mips@FreeBSD.ORG Wed Sep 7 20:16:22 2011 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9B7D106566C for ; Wed, 7 Sep 2011 20:16:22 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 76E068FC14 for ; Wed, 7 Sep 2011 20:16:22 +0000 (UTC) Received: by wwi36 with SMTP id 36so31238wwi.31 for ; Wed, 07 Sep 2011 13:16:21 -0700 (PDT) Received: by 10.227.19.194 with SMTP id c2mr6774662wbb.65.1315426581290; Wed, 07 Sep 2011 13:16:21 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.227.138.18 with HTTP; Wed, 7 Sep 2011 13:16:01 -0700 (PDT) In-Reply-To: References: From: Juli Mallett Date: Wed, 7 Sep 2011 13:16:01 -0700 X-Google-Sender-Auth: n7y2LwLQihLmMWHjdmbuV55x6VA Message-ID: To: Andrew Duane Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "mips@freebsd.org" Subject: Re: Adding board IDs to sys/contrib/octeon-sdk/cvmx-app-init.h X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2011 20:16:22 -0000 On Wed, Sep 7, 2011 at 12:37, Andrew Duane wrote: > I know this is a Cavium maintained file, there's even a comment inside th= at says: > > =C2=A0 =C2=A0/* Set aside a range for customer boards. =C2=A0These number= s are managed > =C2=A0 =C2=A0 ** by Cavium. > =C2=A0 =C2=A0 */ > > Is there a protocol for adding new board IDs? And, would it be a real pro= blem if the board IDs were not between CVMX_BOARD_TYPE_CUST_PRIVATE_MIN and= CVMX_BOARD_TYPE_CUST_PRIVATE_MAX? I'm trying to sort out some code additio= ns to define our private boards, and they already have hardware IDs assigne= d and burned into them that are in the range of 1300 to 1600 or so. Look at the ifdefs I added to that file to handle a couple of vendors who went outside of those ranges or overlapped with other boards. Just add an OCTEON_VENDOR_JUNIPER option and put your board-related stuff behind an ifdef in the SDK and outside of it. > I guess I could read the hardware IDs and add CVMX_BOARD_TYPE_CUST_PRIVAT= E_MIN as an offset, is that a reasonable approach? > > As a related question, is there a protocol for managing kernel configurat= ion files that belong to a private platform? I think probably not managing them in a FreeBSD.org tree makes the most sen= se :)