From owner-freebsd-current@FreeBSD.ORG  Sun Apr 10 11:12:05 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E343816A4CE; Sun, 10 Apr 2005 11:12:05 +0000 (GMT)
Received: from dlb139.neoplus.adsl.tpnet.pl (dln55.neoplus.adsl.tpnet.pl
	[83.24.43.55])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 11C0E43D2D; Sun, 10 Apr 2005 11:12:05 +0000 (GMT)
	(envelope-from w@dln55.neoplus.adsl.tpnet.pl)
Received: from dln55.neoplus.adsl.tpnet.pl (w@localhost [127.0.0.1])
	j3ABC3Uv006255;	Sun, 10 Apr 2005 13:12:03 +0200 (CEST)
	(envelope-from w@dln55.neoplus.adsl.tpnet.pl)
Received: (from w@localhost)j3ABC3Zg006254;
	Sun, 10 Apr 2005 13:12:03 +0200 (CEST)	(envelope-from w)
Date: Sun, 10 Apr 2005 13:12:02 +0200
From: Wiktor Niesiobedzki <bsd@w.evip.pl>
To: current@freebsd.org
Message-ID: <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.1i
cc: sos@freebsd.org
Subject: ATA MkIII - Hang after resume solution
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Apr 2005 11:12:06 -0000

Hi,

I think I found solution to the problem, that after MkIII disks does not
reinit. Solution is simple:

--- /usr/src/sys/dev/ata/ata-pci.c      Fri Apr  8 11:37:47 2005
+++ /tmp/ata-pci.c      Sun Apr 10 13:09:48 2005
@@ -599,8 +599,8 @@
     DEVMETHOD(device_attach,    ata_pcichannel_attach),
     DEVMETHOD(device_detach,    ata_pcichannel_detach),
     DEVMETHOD(device_shutdown,  bus_generic_shutdown),
-    DEVMETHOD(device_suspend,   bus_generic_suspend),
-    DEVMETHOD(device_resume,    bus_generic_resume),
+    DEVMETHOD(device_suspend,   ata_suspend),
+    DEVMETHOD(device_resume,    ata_resume),
 
     /* ATA methods */
     DEVMETHOD(ata_setmode,      ata_pcichannel_setmode),

This is rollback of changes introduced by MkIII. After that change
suspend/resume works again.

Can anybody review this?


Cheers,

Wiktor Niesiobedzki