From owner-svn-src-all@freebsd.org  Fri Jan  1 18:01:32 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E1A9A5EE71;
 Fri,  1 Jan 2016 18:01:32 +0000 (UTC)
 (envelope-from chmeeedalf@gmail.com)
Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com
 [IPv6:2607:f8b0:4003:c01::22e])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0318D1EE5;
 Fri,  1 Jan 2016 18:01:31 +0000 (UTC)
 (envelope-from chmeeedalf@gmail.com)
Received: by mail-ob0-x22e.google.com with SMTP id 18so305439140obc.2;
 Fri, 01 Jan 2016 10:01:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=GHyWbIHLGphJR/DF7lTMa7Fgv27HhnelvfSqCNG0yl8=;
 b=OuBey12+nmzVgGWG6V3sn4e19Ou+YLZDK35GllY0cxVPPAusmYNmpOE4WXoVSO/qSd
 x74VMPw/kKJLUaarpOQfjhexgZ+Txzt9X4i0qzGaI594p8Ae8ez/cF1HZ+0zrfdfsrjE
 fAsjbEtCHzje0MXjjC9ITE+52ux5/zmlrV0lACedz2QbrObLxCilQQI2qHicOpHBSSmc
 wwAGMLDNibH5bSdT99vg9FpN52ES8tNj7OGHzU1HcsUvH5H0IyrQYktBJ0sMJb8YT2ak
 6rM3ynJIqwZGvGfnmdGAHJv1dlz38n6GxpXXNY1L2PjAO9sZiLfM0UVmW2BQ1b5th73U
 8XFQ==
MIME-Version: 1.0
X-Received: by 10.182.241.3 with SMTP id we3mr49200674obc.82.1451671290971;
 Fri, 01 Jan 2016 10:01:30 -0800 (PST)
Sender: chmeeedalf@gmail.com
Received: by 10.182.184.84 with HTTP; Fri, 1 Jan 2016 10:01:30 -0800 (PST)
Received: by 10.182.184.84 with HTTP; Fri, 1 Jan 2016 10:01:30 -0800 (PST)
In-Reply-To: <CAG6CVpX-_ZKFBO1HzhO5ftwWa6gpLW2NKeo6CoRyLAA2N3xcDw@mail.gmail.com>
References: <201601011517.u01FHOCo079299@repo.freebsd.org>
 <CAG6CVpX-_ZKFBO1HzhO5ftwWa6gpLW2NKeo6CoRyLAA2N3xcDw@mail.gmail.com>
Date: Fri, 1 Jan 2016 12:01:30 -0600
X-Google-Sender-Auth: bIF_r44WGaPCC6Hbp9ANz0bbNDo
Message-ID: <CAHSQbTAM1cy6EyYVF4zkWRH3j4kh0tcHh0An-5WuVoy6-OxPLQ@mail.gmail.com>
Subject: Re: svn commit: r293039 - in head/sys/dev: sec tsec
From: Justin Hibbits <jhibbits@freebsd.org>
To: cem@freebsd.org
Cc: src-committers <src-committers@freebsd.org>, svn-src-head@freebsd.org, 
 svn-src-all@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.20
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jan 2016 18:01:32 -0000

On Jan 1, 2016 11:30, "Conrad Meyer" <cem@freebsd.org> wrote:
>
> On Fri, Jan 1, 2016 at 7:17 AM, Justin Hibbits <jhibbits@freebsd.org>
wrote:
> > Author: jhibbits
> > Date: Fri Jan  1 15:17:24 2016
> > New Revision: 293039
> > URL: https://svnweb.freebsd.org/changeset/base/293039
> >
> > Log:
> >   Fix a couple printf formats.
> >
> > ...
> > @@ -235,7 +236,7 @@ sec_probe(device_t dev)
> >                 sc->sc_version = 3;
> >                 break;
> >         default:
> > -               device_printf(dev, "unknown SEC ID 0x%016llx!\n", id);
> > +               device_printf(dev, "unknown SEC ID 0x%16"PRIx64"!\n",
id);
> >                 return (ENXIO);
> >         }
>
> Hi,
>
> The 0 got dropped, which makes this a slightly different format.  The
> zero is ignored if a precision is given, but the 16 in the format
> string represents a field width.  (Either "%016" or "%.16" should
> print the same as the original, I think.)
>
> Best,
> Conrad

Oops, fixed in r293044.
Thanks!

-Justin