From owner-freebsd-mips@FreeBSD.ORG Thu Jun 17 23:37:16 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00DF21065672 for ; Thu, 17 Jun 2010 23:37:16 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id CA20B8FC15 for ; Thu, 17 Jun 2010 23:37:15 +0000 (UTC) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id 73D152C2ACA; Thu, 17 Jun 2010 18:10:12 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VSmyDZ11dFsU; Thu, 17 Jun 2010 18:10:04 -0500 (CDT) Received: from [173.37.10.52] (nat.ironport.com [63.251.108.100]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id 5E60F2C2AAC; Thu, 17 Jun 2010 18:10:04 -0500 (CDT) Message-ID: <4C1AAB2A.5030507@cs.rice.edu> Date: Thu, 17 Jun 2010 18:09:30 -0500 From: Alan Cox User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Randall Stewart References: <20100617.100235.195066307596264499.imp@bsdimp.com> <4B66E1A4-E2A5-471F-9FA4-38B506797272@lakerest.net> <20100617.110504.200754750200158040.imp@bsdimp.com> <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> In-Reply-To: <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2010 23:37:16 -0000 On 6/17/2010 5:30 PM, Randall Stewart wrote: > > On Jun 17, 2010, at 1:05 PM, M. Warner Losh wrote: > >> >> >> It was also a name-space collision, so we were using PG_x instead of >> PG_y in the PTE code due to the overlap. Maybe it all works now, but >> that was the motivation for the change. > > > > Yes, basically if I remember right someone used > > PG_GLOBAL instead of PG_G. This caused the wrong bits > to be set. > > In general I think its a BAD idea to have two name spaces in the > same section of the system (VM) that have similar define's that mean > different things. > > > Far better to KEEP the PTE_xxx or for that matter pick something > else.. Just > NOT PG_xxx There is precedent for the PTE_ prefix: ia64 and powerpc. I would stick with it. (For the historically inclined, the name space collision goes back to CVS revision 1.1 of the relevant files, i.e., 1993.) Alan