Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Apr 2017 22:28:11 +0200
From:      Philip Paeps <philip@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r438598 - in head/graphics: . dspdfviewer
Message-ID:  <20170415202811.GC31045@rincewind.trouble.is>
In-Reply-To: <20170415202244.GA19742@FreeBSD.org>
References:  <201704152016.v3FKGm44007015@repo.freebsd.org> <20170415202244.GA19742@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2017-04-15 20:22:44 (+0000), Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
>On Sat, Apr 15, 2017 at 08:16:48PM +0000, Philip Paeps wrote:
>> New Revision: 438598
>> URL: https://svnweb.freebsd.org/changeset/ports/438598
>>
>> Log:
>>   Dual-screen PDF viewer for LaTeX-beamer
>> ...
>> +PORTVERSION=	1.15.1
>
>Missing DISTVERSIONPREFIX=v here...
>
>> +CMAKE_VERBOSE=	yes
>
>Unneed, batch builds enable it themselves.
>
>> +USE_GITHUB=	yes
>> +GH_ACCOUNT=	dannyedel
>> +GH_PROJECT=	dspdfviewer
>
>Could be dropped as it matches the PORTNAME.
>
>> +GH_TAGNAME=	v1.15.1
>
>Per above (mat@ could probably elaborate).

Thanks for pointing these out.  Santhosh is preparing an update for me 
to commit.

mat: have you considered updating ports-mgmt/portlint to spot these?  
I'm sure I'm not the first (and I won't be the last) to overlook this.

Philip

-- 
Philip Paeps
Senior Reality Engineer
Ministry of Information



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170415202811.GC31045>