From owner-freebsd-ports@FreeBSD.ORG Wed Sep 1 06:31:37 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5D7410656A9; Wed, 1 Sep 2010 06:31:36 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 470E48FC17; Wed, 1 Sep 2010 06:31:36 +0000 (UTC) Received: by fxm4 with SMTP id 4so5264132fxm.13 for ; Tue, 31 Aug 2010 23:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=SP5loXVf+mqQxAaHtOuD4PqVthWL5uaNiBj3tAPmGQY=; b=I2gR7iwLdKBDvFijNb71ktiDbrhOPOej4amkg0H5lA8WR4pqMWi2midjQV4ukXrsKm P3YIDjVPe/+7VEDyO6QPIpXseuDINN8vFx+tqv8ARLFqkS0h5n7RD24jRyO54oPDC6MK nxdrNKfpkSRYoGCXEzParhiu6XgirdW6rhse8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=pZIM85bOWc7L+8HF/Iv1geQIuHpoCJrgMZ9uR8q8ZguGxoO2u3+VuFaXq7Kj78i6c9 A38e+wzlZ5y0P02F+ASmut+QCVdciqS5BIXFw85kZ2qOIxSIAqnm6pLFU8aSKjj51Fk+ /W09uLu9+89xdO3XQ2fS9394bH1Mof7oIXQVo= MIME-Version: 1.0 Received: by 10.239.142.6 with SMTP id e6mr162612hba.31.1283322694915; Tue, 31 Aug 2010 23:31:34 -0700 (PDT) Received: by 10.239.155.129 with HTTP; Tue, 31 Aug 2010 23:31:34 -0700 (PDT) In-Reply-To: References: <4C7D76A6.7080401@DataIX.net> Date: Wed, 1 Sep 2010 01:31:34 -0500 Message-ID: From: Scot Hetzel To: bf1783@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: maho@freebsd.org, freebsd-ports@freebsd.org Subject: Re: math/blas linking to gfortran with LDADD?= -lgfortran X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2010 06:31:37 -0000 On Tue, Aug 31, 2010 at 11:58 PM, b. f. wrote: > On 9/1/10, Scot Hetzel wrote: >> On Tue, Aug 31, 2010 at 10:06 PM, b. f. wrote: >>> On 8/31/10, jhell wrote: > >>So according to bsd.own.mk, this is the correct test for the math/blas >>port to determine if profiling libraries should be built: >> >>.if !defined(WITHOUT_PROFILE) >>PLIST_FILES+=3D =A0 lib/libblas_p.a >>.endif > > No, you are leaving the order out of account. =A0Apart from local and > custom makefiles, the makefiles are included so: > > /usr/share/mk/sys.mk > /etc/make.conf > /usr/share/mk/bsd.compat.mk > usr/share/mk/bsd.cpu.mk > Makefile(for math/blas) > /usr/share/mk/bsd.port.mk > /usr/share/mk/bsd.own.mk > /usr/ports/Mk/bsd.port.mk > /usr/ports/Mk/bsd.commands.mk > /usr/ports/Mk/bsd.perl.mk > /usr/ports/Mk/bsd.gcc.mk > /usr/ports/Mk/bsd.perl.mk > /usr/ports/Mk/bsd.licenses.mk > /usr/ports/Mk/bsd.sites.mk > ... > > So if NO_PROFILE or NOPROFILE is defined, a test for WITHOUT_PROFILE > in Makefile will still fail because NO_PROFILE is not mapped to > WITHOUT_PROFILE until bsd.own.mk, after the test. =A0Just be patient and > we'll sort it out. > >> >> As can be seen, NOPROFILE is deprecated. > > It may be deprecated, but it will still take effect without > BURN_BRIDGES, and so still must be accounted for. > >> >> NOTE: WITHOUT_PROFILE would need to be set in /etc/make.conf (instead >> of /etc/src.conf) to disable building profiled libraries in the >> FreeBSD sources and the math/blas port. > > No, it will still take effect, after the math/blas Makefile is parsed, > unless _WITHOUT_SRCCONF is defined. =A0See bsd.own.mk. > > b. > I created PR 150174, before I got your reply: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D150174 I changed the port to use the OPTIONS framework to enable/disable profiled libraries. The only thing I didn't take into account was the bsd.lib.mk was still pulling in /etc/src.conf. To fix this we just need to add _WITHOUT_SRCCONF to the MAKE_ARGS (should they be MAKE_ENV?). Scot