Date: Mon, 3 Jul 2000 13:04:32 -0700 (PDT) From: kbyanc@posi.net To: FreeBSD-gnats-submit@freebsd.org Subject: ports/19681: patch to fix devel/libcoro Message-ID: <200007032004.NAA73071@kbyanc.corp.ONElist.com>
next in thread | raw e-mail | index | archive | help
>Number: 19681 >Category: ports >Synopsis: patch to fix devel/libcoro >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 03 13:10:00 PDT 2000 >Closed-Date: >Last-Modified: >Originator: Kelly Yancey >Release: FreeBSD 4.0-STABLE i386 >Organization: eGroups.com -- http://www.eGroups.com/ >Environment: >Description: I erroniously tried to make libcoro into a shared library. While the tests bundled with the library passed, I have since been informed by the author that the library is position-independent unfriendly and that more ellaborate code will fail. Reverted back to static library (not a big deal, the library itself is just a few K). I left this as 'non-critical' since I doubt there is anyone using the port yet. On a related note, I'll be posting a follow-up patch to the still-open PR ports/19466 (which depends on libcoro). Thanks, Kelly >How-To-Repeat: >Fix: Index: Makefile =================================================================== RCS file: /home/cvs/ports/devel/libcoro/Makefile,v retrieving revision 1.1 diff -u -r1.1 Makefile --- Makefile 2000/06/23 10:08:04 1.1 +++ Makefile 2000/07/03 19:40:35 @@ -15,7 +15,6 @@ ONLY_FOR_ARCHS= i386 -INSTALLS_SHLIB= yes HAS_CONFIGURE= yes CONFIGURE_ARGS= --arch arch/x86-freebsd Index: patches/patch-ab =================================================================== RCS file: /home/cvs/ports/devel/libcoro/patches/patch-ab,v retrieving revision 1.1 diff -u -r1.1 patch-ab --- patches/patch-ab 2000/06/23 10:08:05 1.1 +++ patches/patch-ab 2000/07/03 19:54:02 @@ -1,39 +1,30 @@ ---- arch/x86-freebsd/Makefile.in.orig Fri Jun 23 12:43:22 2000 -+++ arch/x86-freebsd/Makefile.in Fri Jun 23 12:50:30 2000 -@@ -1,22 +1,27 @@ +--- arch/x86-freebsd/Makefile.in.orig Mon Jul 3 12:52:20 2000 ++++ arch/x86-freebsd/Makefile.in Mon Jul 3 12:53:50 2000 +@@ -1,10 +1,13 @@ -CFLAGS=-O2 -Wall +CFLAGS?=-O2 -Wall -+CFLAGS+=-fPIC -DPIC MAN=@MANSRC@ LINST=@LINST@ HINST=@HINST@ MINST=@MINST@ --all: libcoro.a -+SHARED_LIB=libcoro.so.1 -+SHORT_SHARED_LIB=libcoro.so - --libcoro.a: coro.o -+all: $(SHARED_LIB) ++BSD_INSTALL_PROGRAM?=install -C -m 644 ++BSD_INSTALL_DATA?=install -C -m 644 + -+$(SHARED_LIB): coro.o - rm -f $@ -- ar rcs $@ coro.o -+ $(CC) -shared -Wl,-soname -Wl,$(SHARED_LIB) -o $(SHARED_LIB) coro.o + all: libcoro.a + libcoro.a: coro.o +@@ -14,9 +17,9 @@ coro.o: coro.h --install: libcoro.a coro.h $(MAN) + install: libcoro.a coro.h $(MAN) - install -m 644 libcoro.a $(LINST)/libcoro.a - install -m 644 coro.h $(HINST)/coro.h - install -m 644 $(MAN) $(MINST)/man2/coro.2 -+install: all $(MAN) -+ $(BSD_INSTALL_PROGRAM) $(SHARED_LIB) $(LINST)/$(SHARED_LIB) -+ ln -sf $(LINST)/$(SHARED_LIB) $(LINST)/$(SHORT_SHARED_LIB) ++ $(BSD_INSTALL_PROGRAM) libcoro.a $(LINST)/libcoro.a + $(BSD_INSTALL_DATA) coro.h $(HINST)/coro.h -+ $(BSD_INSTALL_MAN) $(MAN) $(MINST)/man2/coro.2 ++ $(BSD_INSTALL_DATA) $(MAN) $(MINST)/man2/coro.2 clean: -- rm -f libcoro.a coro.o -+ rm -f $(SHARED_LIB) coro.o + rm -f libcoro.a coro.o Index: pkg/PLIST =================================================================== RCS file: /home/cvs/ports/devel/libcoro/pkg/PLIST,v retrieving revision 1.1 diff -u -r1.1 PLIST --- pkg/PLIST 2000/06/23 10:08:05 1.1 +++ pkg/PLIST 2000/07/03 19:45:30 @@ -1,4 +1,3 @@ -lib/libcoro.so -lib/libcoro.so.1 +lib/libcoro.a include/coro.h >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007032004.NAA73071>