From owner-cvs-src@FreeBSD.ORG  Sun Jul  3 23:57:35 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8BD1116A41C;
	Sun,  3 Jul 2005 23:57:35 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz
	[60.234.149.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1AE5B43D46;
	Sun,  3 Jul 2005 23:57:35 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id 71F451CCD4; Mon,  4 Jul 2005 11:57:33 +1200 (NZST)
Date: Mon, 4 Jul 2005 11:57:33 +1200
From: Andrew Thompson <thompsa@freebsd.org>
To: Mike Silbersack <silby@silby.com>
Message-ID: <20050703235733.GA8138@heff.fud.org.nz>
References: <200507031824.j63IO3Bs009536@repoman.freebsd.org>
	<20050703184013.U21939@odysseus.silby.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050703184013.U21939@odysseus.silby.com>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net bridge.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2005 23:57:35 -0000

On Sun, Jul 03, 2005 at 06:41:36PM -0500, Mike Silbersack wrote:
> 
> On Sun, 3 Jul 2005, Andrew Thompson wrote:
> 
> >thompsa     2005-07-03 18:24:03 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> >   sys/net              bridge.c
> > Log:
> > Check the alignment of the IP header before passing the packet up to the
> > packet filter. This would cause a panic on architectures that require 
> > strict
> > alignment such as sparc64, ia64 and ppc.
> 
> What's the route that a packet takes before it gets to the bridge?  If it 
> goes through ether_input, it would make sense to put the alignment there 
> when necessary.
 
Both bridges tap their packets off near the end of ether_input(). Since
we only need to check alignment when using pfil(9) and each bridge has
its own knobs to control filtering, it seems best to leave it where it
is at the moment.

> By the way, which network drivers are not aligning to the ip header right 
> now?
 
I do not know. Maybe the originator of the PR can share what hardware he
is using.


Andrew