Date: Fri, 27 Dec 2013 05:10:01 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-arm@FreeBSD.org Subject: Re: arm/185046: commit references a PR Message-ID: <201312270510.rBR5A1HY017885@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR arm/185046; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: arm/185046: commit references a PR Date: Fri, 27 Dec 2013 05:01:20 +0000 (UTC) Author: adrian Date: Fri Dec 27 05:01:13 2013 New Revision: 259936 URL: http://svnweb.freebsd.org/changeset/base/259936 Log: Revert r252694 - which attempted to fix bit emulation for armv6/armv7. This seems to cause issues with jemalloc + {dhclient, sshd}. Thus, revert this for now until the root cause can be found and fixed. This should quieten some runtime problems with the Raspberry Pi. PR: kern/185046 MFC after: 3 days Modified: head/sys/arm/arm/pmap-v6.c Modified: head/sys/arm/arm/pmap-v6.c ============================================================================== --- head/sys/arm/arm/pmap-v6.c Fri Dec 27 04:30:32 2013 (r259935) +++ head/sys/arm/arm/pmap-v6.c Fri Dec 27 05:01:13 2013 (r259936) @@ -3094,21 +3094,16 @@ validate: if ((m->oflags & VPO_UNMANAGED) == 0) { vm_page_aflag_set(m, PGA_WRITEABLE); /* - * Enable write permission if the access type - * indicates write intention. Emulate modified - * bit otherwise. + * XXX: Skip modified bit emulation for now. + * The emulation reveals problems + * that result in random failures + * during memory allocation on some + * platforms. + * Therefore, the page is marked RW + * immediately. */ - if ((access & VM_PROT_WRITE) != 0) { - npte &= ~(L2_APX); - /* - * The access type and permissions - * indicate that the page will be - * written as soon as returned from - * fault service. - * Mark it dirty from the outset. - */ - vm_page_dirty(m); - } + npte &= ~(L2_APX); + vm_page_dirty(m); } else npte &= ~(L2_APX); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312270510.rBR5A1HY017885>