From owner-svn-src-projects@FreeBSD.ORG  Sat Sep  3 10:10:21 2011
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F3028106564A;
	Sat,  3 Sep 2011 10:10:20 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id CF5E78FC12;
	Sat,  3 Sep 2011 10:10:20 +0000 (UTC)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id 7436B46B23;
	Sat,  3 Sep 2011 06:10:19 -0400 (EDT)
Date: Sat, 3 Sep 2011 11:10:19 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: mdf@FreeBSD.org
In-Reply-To: <CAMBSHm-+C9t2Vnwh5z=c8Tg9VEQHGv0pGoK2t+p6w4G=d4MNqA@mail.gmail.com>
Message-ID: <alpine.BSF.2.00.1109031107100.34583@fledge.watson.org>
References: <201109021852.p82IqH1M011851@svn.freebsd.org>
	<CAMBSHm-+C9t2Vnwh5z=c8Tg9VEQHGv0pGoK2t+p6w4G=d4MNqA@mail.gmail.com>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r225351 - projects/ino64/sys/ufs/ufs
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Sep 2011 10:10:21 -0000

On Fri, 2 Sep 2011, mdf@FreeBSD.org wrote:

> Is anyone using UFS_EXTATTR_AUTOSTART?  I think the code is now correct for 
> the endpoint of the returned dirent's, but it would be nice to have a review 
> and/or someone test the code.

Good question.  UFS_EXTATTR_AUTOSTART was the precursor to UFS2 extended 
attributes (which integrated EAs more tightly into the file sytem design), so 
is relevant only on UFS1.  Anyone using ACLs, MAC, etc, on UFS1 will be using 
at least options UFS_EXTATTR.

This code is pretty easy to test -- create a UFS1 file system, and use 
extattrctl to configure storage:

   mkdir -p /.attribute/system
   cd /.attribute/system
   extattrctl initattr -p / 388 posix1e.acl_access
   extattrctl initattr -p / 388 posix1e.acl_default

Then unmount, set the "acls" flag with tunefs, and remount.  If ACLs work, 
then the attributes were properly configured when the file system was mounted.

I imagine it's not seeing a lot of use with widespread deployment of UFS2, but 
when we have broken it in the past, we have received bug reports.

Robert