From owner-freebsd-bugs@FreeBSD.ORG  Mon May 18 02:13:49 2015
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 83556FF0
 for <freebsd-bugs@FreeBSD.org>; Mon, 18 May 2015 02:13:49 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6DCC41C5A
 for <freebsd-bugs@FreeBSD.org>; Mon, 18 May 2015 02:13:49 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4I2Dnqw022845
 for <freebsd-bugs@FreeBSD.org>; Mon, 18 May 2015 02:13:49 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 196483] [patch] change vfs_setopt{,_part}(...)'s len parameter
 to fix possible DoS
Date: Mon, 18 May 2015 02:13:49 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: mckusick@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-196483-8-cTWXltW6Q6@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-196483-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-196483-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 02:13:49 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196483

--- Comment #3 from Kirk McKusick <mckusick@FreeBSD.org> ---
Comment on attachment 151321
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151321
0001-HBSD-change-vfs_setopt-_part-.-s-len-type-to-check-b.patch

I agree with the sentiment reported here. But it is incomplete. The type of the
len field declared in struct vfsopt (declared in sys/mount.h) needs to be
changed to size_t. Also the type of field len in struct mntarg (declared in
kern/vfs_mount.c)
needs to be changed to size_t. Another function that needs to have its len
parameter changed to size_t is vfs_copyopt. In short, a pass needs to be made
over kern/vfs_mount.c to make the use of len consistent throughout. Then the
callers of the affected functions need to ensure that they are calling with
appropriate parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.