From owner-freebsd-arm@FreeBSD.ORG  Tue Apr 28 17:59:56 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9FF30FD8
 for <freebsd-arm@freebsd.org>; Tue, 28 Apr 2015 17:59:56 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 83FE3105A
 for <freebsd-arm@freebsd.org>; Tue, 28 Apr 2015 17:59:56 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t3SHxuaf057230
 for <freebsd-arm@freebsd.org>; Tue, 28 Apr 2015 17:59:56 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3SHxum7057229;
 Tue, 28 Apr 2015 17:59:56 GMT (envelope-from daemon-user)
Date: Tue, 28 Apr 2015 17:59:56 +0000
To: freebsd-arm@freebsd.org
From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2340: Support for Alpine platform from
 Annapurna Labs
Message-ID: <21455fea077987085eccac6399a9c903@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2340: Support for Alpine platform from Annapurna Labs
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-aay5lnojfw75bfxuj2t6>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-ueipubl3jymguf56hiqy>
X-Phabricator-Cc: <PHID-USER-xvjulcphpj66vffzpxft>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-gclxe3zq7xamd5hpjagv-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-gclxe3zq7xamd5hpjagv-req@FreeBSD.org>
Thread-Index: MzFmODEzYTliMzhlZDlhOTEyM2NlYTg2YmJiIFU/ypw=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2015 17:59:56 -0000

imp added a comment.

Just a quick peek between other things, looking goodish. Will look in more detail in a bit.


INLINE COMMENTS
  sys/arm/annapurna/alpine/alpine_machdep_mp.c:83 Shouldn't this be lower case?

REVISION DETAIL
  https://reviews.freebsd.org/D2340

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, ian, andrew, imp
Cc: meloun-miracle-cz, onwahe-gmail-com, freebsd-arm