From owner-cvs-src@FreeBSD.ORG Mon May 29 21:31:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73A6716A449; Mon, 29 May 2006 21:31:29 +0000 (UTC) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 449D343E22; Mon, 29 May 2006 21:30:28 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4TLSvwJ025596; Mon, 29 May 2006 21:28:57 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4TLSu32025595; Mon, 29 May 2006 21:28:56 GMT (envelope-from tegge) Message-Id: <200605292128.k4TLSu32025595@repoman.freebsd.org> From: Tor Egge Date: Mon, 29 May 2006 21:28:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exit.c src/sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 21:31:35 -0000 tegge 2006-05-29 21:28:56 UTC FreeBSD src repository Modified files: sys/kern kern_exit.c sys/vm vm_extern.h vm_glue.c vm_map.c vm_map.h vm_meter.c Log: Close race between vmspace_exitfree() and exit1() and races between vmspace_exitfree() and vmspace_free() which could result in the same vmspace being freed twice. Factor out part of exit1() into new function vmspace_exit(). Attach to vmspace0 to allow old vmspace to be freed earlier. Add new function, vmspace_acquire_ref(), for obtaining a vmspace reference for a vmspace belonging to another process. Avoid changing vmspace refcount from 0 to 1 since that could also lead to the same vmspace being freed twice. Change vmtotal() and swapout_procs() to use vmspace_acquire_ref(). Reviewed by: alc Revision Changes Path 1.289 +2 -29 src/sys/kern/kern_exit.c 1.78 +2 -0 src/sys/vm/vm_extern.h 1.215 +3 -6 src/sys/vm/vm_glue.c 1.374 +91 -16 src/sys/vm/vm_map.c 1.119 +0 -1 src/sys/vm/vm_map.h 1.86 +6 -1 src/sys/vm/vm_meter.c