From owner-svn-ports-head@FreeBSD.ORG Sun Dec 21 19:28:04 2014 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DDDB76EE; Sun, 21 Dec 2014 19:28:04 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B50ED3919; Sun, 21 Dec 2014 19:28:04 +0000 (UTC) Received: from [192.168.0.187] (75-173-123-43.albq.qwest.net [75.173.123.43]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 1610B1140AC; Sun, 21 Dec 2014 12:28:03 -0700 (MST) References: <201412201559.sBKFxl9d088764@svn.freebsd.org> <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org> <549707F1.4070205@FreeBSD.org> Mime-Version: 1.0 (1.0) In-Reply-To: <549707F1.4070205@FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPad Mail (12B440) From: Adam Weinberger Subject: Re: svn commit: r375010 - head/Mk Date: Sun, 21 Dec 2014 12:28:04 -0700 To: Steve Wills Cc: "svn-ports-head@FreeBSD.org" , "svn-ports-all@FreeBSD.org" , "ports-committers@FreeBSD.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Dec 2014 19:28:05 -0000 > On Dec 21, 2014, at 10:48, Steve Wills wrote: >=20 > On 12/21/14 15:15, Adam Weinberger wrote: >>> On 20 Dec, 2014, at 8:59, Steve Wills >>> wrote: >>>=20 >>> Author: swills Date: Sat Dec 20 15:59:46 2014 New Revision: >>> 375010 URL: https://svnweb.freebsd.org/changeset/ports/375010=20 >>> QAT: https://qat.redports.org/buildarchive/r375010/ >>>=20 >>> Log: Make using GitHub releases easier >>>=20 >>> Differential Revision: https://reviews.freebsd.org/D1340 With >>> hat: portmgr >>>=20 >>> -# -# GitHub files can also be obtained, without the need for any >>> of the above, by doing: -# -# MASTER_SITES=3D >>> http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?= dummy=3D/ > -# >>=20 >> That shortcut code still works, and it's still simpler than using=20 >> USE_GITHUB and having to keep track of commit hashes on every >> update. Why remove it? >>=20 >> The PH says, "If the distribution file comes from a specific >> commit or tag on GitHub for which there is no officially released >> file, [...]". That code block is a way to get it when there IS an=20 >> officially released file. >=20 > Wouldn't you still have to do work to update the distinfo if the > commit hash changes? Sure, same as other ports. Only difference is that, same as other ports, you= don't need to come up with the commit SHA hash as well. You're portmgr, it'= s your call of course, I just thought it was a nice alternative for ports wi= th release tarballs on github to use a simpler method. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org