From owner-svn-ports-all@freebsd.org  Fri Nov 23 04:01:28 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 144011139C25;
 Fri, 23 Nov 2018 04:01:28 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AF16F7482E;
 Fri, 23 Nov 2018 04:01:27 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 9B16E12B0D; Fri, 23 Nov 2018 04:01:27 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: Don Lewis <truckman@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org>,
 svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r485501 - head/editors/openoffice-4
References: <201811210710.wAL7AB0c038961@repo.freebsd.org>
 <20181121135626.zxyljkaow3ay7r6n@ogg.in.absolight.net>
 <tkrat.d645477da5bcec19@FreeBSD.org>
 <20181121224753.qkh4eqejwsdphnf3@atuin.in.mat.cc>
 <alpine.LSU.2.21.1811221925440.7079@anthias.pfeifer.com>
Date: Fri, 23 Nov 2018 05:01:24 +0100
In-Reply-To: <alpine.LSU.2.21.1811221925440.7079@anthias.pfeifer.com> (Gerald
 Pfeifer's message of "Thu, 22 Nov 2018 19:34:50 +0100 (CET)")
Message-ID: <zhu0-4f3f-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: AF16F7482E
X-Spamd-Result: default: False [2.47 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_SPAM_LONG(0.81)[0.814,0];
 NEURAL_SPAM_MEDIUM(0.91)[0.910,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US];
 NEURAL_SPAM_SHORT(0.75)[0.751,0]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Nov 2018 04:01:28 -0000

Gerald Pfeifer <gerald@pfeifer.com> writes:

> On Wed, 21 Nov 2018, Mathieu Arnold wrote:
>
>>> I've used "make makesum" many times and this is the first time that
>>> unowinreg.dll got dropped from distinfo.
>> The most probable reason is that you had the option enabled before, 
>> and you disabled it since.
>
> In the scripts I use to maintain my ports I have the following
>
>   make OPTIONS_DEFAULT="`make -V OPTIONS_DEFINE`" ... MASTER_SITE_BACKUP= makesum
>
> to account for that situation.

Here're a number of alternative workarounds:

astro/geographiclib:
  # Memorandum: use "make fetch makesum" to makesum all distfiles.
  .ifmake makesum || distclean
  OPTIONS_DEFAULT=	${MAKESUM_OPTIONS_DEFAULT}
  .endif

devel/android-tools-adb:
  .if make(makesum) # for optional distfiles
  .MAKEFLAGS:	WITH="${OPTIONS_DEFINE}"
  .endif

mail/exim:
  .if make(makesum) && !defined(FETCH_ALL)
  .error "You forgot to define FETCH_ALL to create the sane distinfo"
  .endif

net/rsync:
  .if make(makesum)
  DISTFILES+=	${PORTNAME}-patches-${PORTVERSION}${EXTRACT_SUFX}
  .endif