From nobody Mon Jul 6 13:28:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gv4tk5l17z6jYHx for ; Mon, 06 Jul 2026 13:28:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gv4tk3R88z3rZQ for ; Mon, 06 Jul 2026 13:28:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783344510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GIjZyq/aX8YYPjEf5TtvoNZ6oAWQ1Xv0tFkMpZRtKXY=; b=RzQoyVz//Xmaz0xHwFg1UU5mV52PPpe4nCIBMArwbhYCskBgPLQ/8L/8qYm2B/51Exzd1g PYT6uEzmmg6ozTNCwKQopOqnse6oqEwDj9E10kDBx6OLGgvqPHOb478Ft3S2UZ3X5AcWzY BzYtXRT7IOr8Y655SV5EhLbnxcyeb/NyHqKG4OexoPveNM+KbRkgtRpz5whre6mmbMxZRJ 9cwvvijD5CKiyVbxy3jzHvJ53Iu2MAjyWNOvWD+XFmtarYGUxIP/6BDGYl4RaF5eSCmRXC 994dWtXGZPS5K6ebfrRHyI5ZPJZ4S2hobqpnPLHfKzn4/tdLlG9ZnXj45JUO8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783344510; a=rsa-sha256; cv=none; b=Lqg/auhnxRvVhy2X5R+mrEe8oXws+AlCozUg78hvcUgW5zjmUs6qfxwIwBD+Uk1/yw4n0z lnrx5OlUa8rqmi5dDHxY4NgTBAAgVQefDMofQ8qAh8WEnSwPlSKA0ePYf30Wi2KONnm9ew 15GOmgUwTZqu+Z7vudfGZOn3+0LY9VbjYYM6JvKJYHtcEPEwW3N3Etr5yVrrw9mfLKKpSS 98Z5V6iq1Zzj0fOyTsU2bQYRLYimwelCKX5/a7t3ykWbYwxwmpE03Ijk+T0nHzxcS3UddW uOnEYfXCpSb2H5xz/SfGz/ZcRZ0sF0fvStLhkjtEByInQqxgC+QZIOgcieY7gw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783344510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GIjZyq/aX8YYPjEf5TtvoNZ6oAWQ1Xv0tFkMpZRtKXY=; b=H7pjow5sqoHbpycdREJA7vJve3AlaTXL3TE/1uqzkrO76Xhw9eGtmmNdA/l7h5fgkBmhuu AmE7Kn7+norn7kZX5LisgxS9YOsnk4vD9zP93ttcczcaQTOutcORJl5atsckIG1gntoqmH wSrMorDyj2VENEWsH/YRcLJbjsNbzC9RSCbbvWueQB9o7r34fmgFzCw5gDHQKgSn/cVn2I x2H3HpmLonKVDs7bUrX0iNJ5Rl5C1nBcHxPsfcBOybzan6Q6cVwFWBXJxvri6EtUedZ1e+ suJU17hqFI3cRcsDFiRsFxXssTyUrBjPJjVAnrLKKuBZ4je/JjuXMQsJCzKviw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gv4tj6XDgz15gr for ; Mon, 06 Jul 2026 13:28:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40b2c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 06 Jul 2026 13:28:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b56b601c5ba6 - main - dtrace: Improve DOF string table validation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b56b601c5ba603031312b9bc7ae895ecb0dcdaec Auto-Submitted: auto-generated Date: Mon, 06 Jul 2026 13:28:29 +0000 Message-Id: <6a4bad7d.40b2c.65f6fa75@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b56b601c5ba603031312b9bc7ae895ecb0dcdaec commit b56b601c5ba603031312b9bc7ae895ecb0dcdaec Author: Mark Johnston AuthorDate: 2026-07-06 13:21:24 +0000 Commit: Mark Johnston CommitDate: 2026-07-06 13:21:24 +0000 dtrace: Improve DOF string table validation The check for a nul terminator implicitly assumes that the section size is positive. Make the assumption explicit. Reviewed by: christos MFC after: 2 weeks Sponsored by: CHERI Research Centre Differential Revision: https://reviews.freebsd.org/D57977 --- sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c b/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c index aa8716908cb1..ff31d806664b 100644 --- a/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c +++ b/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c @@ -14288,8 +14288,9 @@ dtrace_dof_slurp(dof_hdr_t *dof, dtrace_vstate_t *vstate, cred_t *cr, return (-1); } - if (sec->dofs_type == DOF_SECT_STRTAB && *((char *)daddr + - sec->dofs_offset + sec->dofs_size - 1) != '\0') { + if (sec->dofs_type == DOF_SECT_STRTAB && (sec->dofs_size == 0 || + *((char *)daddr + sec->dofs_offset + sec->dofs_size - 1) != + '\0')) { dtrace_dof_error(dof, "non-terminating string table"); return (-1); }