Date: Thu, 12 Apr 2018 11:11:25 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r467145 - head/Mk Message-ID: <201804121111.w3CBBP0x053066@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Thu Apr 12 11:11:25 2018 New Revision: 467145 URL: https://svnweb.freebsd.org/changeset/ports/467145 Log: Try and prevent people from adding github archive urls. If you use the archive URL directly, you end up having non unique distfiles named 0.9.5.tar.gz or v2.2.2.tar.gz, and soon, another port ends up having the same version, and boom. Reviewed by: bdrewery Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D15039 Modified: head/Mk/bsd.sites.mk (contents, props changed) Modified: head/Mk/bsd.sites.mk ============================================================================== --- head/Mk/bsd.sites.mk Thu Apr 12 11:07:37 2018 (r467144) +++ head/Mk/bsd.sites.mk Thu Apr 12 11:11:25 2018 (r467145) @@ -343,6 +343,11 @@ MASTER_SITE_GENTOO+= \ ftp://gentoo.inode.at/source/%SUBDIR%/ .endif +# Keep this before USE_GITHUB +.if !empty(MASTER_SITES:M*/github.com/*/archive/*) +DEV_WARNING+= "MASTER_SITES contains ${MASTER_SITES:M*/github.com/*/archive/*}, please use USE_GITHUB instead." +.endif + .if !defined(IGNORE_MASTER_SITE_GITHUB) # # In order to use GitHub your port must define USE_GITHUB and the following
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804121111.w3CBBP0x053066>