From owner-svn-src-all@freebsd.org  Wed Sep  2 15:18:18 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0B5783D9E90;
 Wed,  2 Sep 2020 15:18:18 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BhSHs6WW1z4rFx;
 Wed,  2 Sep 2020 15:18:17 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from [192.168.0.5] (unknown [181.52.72.201])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: pfg)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 2340024AA9;
 Wed,  2 Sep 2020 15:18:17 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route
 net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu
 netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph...
To: Alexey Dokuchaev <danfe@freebsd.org>,
 Michael Tuexen <tuexen@fh-muenster.de>
Cc: Mateusz Guzik <mjg@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <202009012119.081LJERb018106@repo.freebsd.org>
 <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de>
 <20200902020507.GA38274@FreeBSD.org>
From: Pedro Giffuni <pfg@FreeBSD.org>
Organization: FreeBSD
Message-ID: <eba32e79-4b90-ecce-7bbb-455f691d4444@FreeBSD.org>
Date: Wed, 2 Sep 2020 10:18:15 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200902020507.GA38274@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2020 15:18:18 -0000


On 01/09/2020 21:05, Alexey Dokuchaev wrote:
> On Wed, Sep 02, 2020 at 12:41:43AM +0200, Michael Tuexen wrote:
>>> On 1. Sep 2020, at 23:19, Mateusz Guzik <mjg@FreeBSD.org> wrote:
>>> Author: mjg
>>> Date: Tue Sep  1 21:19:14 2020
>>> New Revision: 365071
>>> URL: https://svnweb.freebsd.org/changeset/base/365071
>>>
>>> Log:
>>>   net: clean up empty lines in .c and .h files
>> Hi Mateusz,
>>
>> which rules are enforced? Why?
> This is common sense.  I can't count how often I wanted to hack on
> something in the base/kernel and was turned away by this atrocious
> excessive whitespace mess.
>
> Thank you Mateusz for cleaning this up.

I honestly don't care much, but spaces do no harm and can make the code 
more readable. Sort of a silent comment, or what you do in written 
language when you start a new paragraph.

Pedro.