From owner-freebsd-current@FreeBSD.ORG Tue Aug 5 18:58:50 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 745AA106564A for ; Tue, 5 Aug 2008 18:58:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 065DF8FC12 for ; Tue, 5 Aug 2008 18:58:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m75IwXKs094564; Tue, 5 Aug 2008 14:58:34 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Tue, 5 Aug 2008 13:28:17 -0400 User-Agent: KMail/1.9.7 References: <20080727125413.GG1345@garage.freebsd.pl> <20080731013229.9d342ee5.nork@FreeBSD.org> <20080806004557.6e538e5c.nork@FreeBSD.org> In-Reply-To: <20080806004557.6e538e5c.nork@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808051328.18308.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 05 Aug 2008 14:58:34 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7946/Tue Aug 5 13:44:22 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx X-Mailman-Approved-At: Tue, 05 Aug 2008 20:48:33 +0000 Cc: freebsd-fs@freebsd.org, Ulf Lilleengen , Pawel Jakub Dawidek , Jeremy Chadwick , Norikatsu Shigemura , Lambrev , Randy Bush , Stefan@freebsd.org, OutBackdingo Subject: Re: ZFS patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 18:58:50 -0000 On Tuesday 05 August 2008 11:45:57 am Norikatsu Shigemura wrote: > On Thu, 31 Jul 2008 01:32:29 +0900 > Norikatsu Shigemura wrote: > > > However, this feature is a bit undocumented yet, and it didn't work correctly > > > for me. But you can always test it out. > > I'm using zfsboot on my note PC, and not using UFS. I know many > > problems about it:-). > > 1. zpool configuration is too limited, only single and mirror > > usable. If you want to zfsboot, you can't use RAIDZ, striping > > and cache(zpool add ... cache ...):-(. > > I missed. zfsboot is disregarded zpool cache rather than supports it. > > > SEE ALSO: > > http://lists.freebsd.org/pipermail/freebsd-fs/2008-July/004895.html > > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/125878 > > I found some zfsboot issues, please apply following patches: > 1. zfsboot2 (boot2) doesn't %d (printf), so change %d to %u. > 2. chase new zpool versioning as SPA_VERSION. > Obtained from: sys/cddl/contrib/opensolaris/uts/common/sys/fs/zfs.h > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > --- sys/boot/zfs/zfsimpl.c.orig 2008-07-28 01:54:49.194419000 +0900 > +++ sys/boot/zfs/zfsimpl.c 2008-08-05 23:48:12.035247220 +0900 > @@ -656,8 +656,8 @@ > return (EIO); > } > > - if (val != ZFS_VERSION) { > - printf("ZFS: unsupported ZFS version %d\n", (int) val); > + if (val > SPA_VERSION) { > + printf("ZFS: unsupported ZFS version %u (should be %u)\n", (int) val, (int) SPA_VERSION); > return (EIO); > } > > --- sys/cddl/boot/zfs/zfsimpl.h.orig 2008-07-28 01:54:49.296418000 +0900 > +++ sys/cddl/boot/zfs/zfsimpl.h 2008-08-06 00:07:41.871760182 +0900 > @@ -448,19 +448,24 @@ > /* > * On-disk version number. > */ > -#define ZFS_VERSION_1 1ULL > -#define ZFS_VERSION_2 2ULL > -#define ZFS_VERSION_3 3ULL > -#define ZFS_VERSION_4 4ULL > -#define ZFS_VERSION_5 5ULL > -#define ZFS_VERSION_6 6ULL > +#define SPA_VERSION_1 1ULL > +#define SPA_VERSION_2 2ULL > +#define SPA_VERSION_3 3ULL > +#define SPA_VERSION_4 4ULL > +#define SPA_VERSION_5 5ULL > +#define SPA_VERSION_6 6ULL FYI, style(9) prefers '#define' to '#define'. Keeping with the existing style would likely shorten the diffs. -- John Baldwin