From owner-freebsd-fs@freebsd.org Mon Mar 6 18:52:42 2017 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D72DECFC6B6 for ; Mon, 6 Mar 2017 18:52:42 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B1E81818; Mon, 6 Mar 2017 18:52:42 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-lf0-x242.google.com with SMTP id g70so12585164lfh.3; Mon, 06 Mar 2017 10:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=0fHJLbvLeR5i1dw8OzOFlFz9XzIrrQgGkqvDMLSAtes=; b=QZCIzJdtLvivpi3cRaG+2J9sv0IntiPzjkfCGAn6HE6UUZL/6vQesYi98KePIhPK9B 5zJZAMq77PRfEllPggWJ8p0n3kyLPjCNvtmkAFPfNCNtt1NU7ZJeq54rp3PfXLnlFYi7 b55xLqQ1jAyOorkoF+t8t0VEtmXuyWzJcQyeUVz3xXkkXsAWeoSm3OKrywSaFxMFzJ8S pKD5ar9lVHA9kCNRADYbAhIh9JJGoZbIAQt3n6NKEjLgRZjIKTyvNy9C1h4H7N/MT9rT /qES6o+wJUmUMSpXIhw543ksBN3cIA4OsWUK9HiIwfd4lEQvHqG5DJsD3cW2P7Tl8qoV 0iFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=0fHJLbvLeR5i1dw8OzOFlFz9XzIrrQgGkqvDMLSAtes=; b=WBg/Y+H6R1WW679CEUSDK9o1PkUIiuFxAY1j53UdTmDVjOb+5fK5IlpuR4DjUflpjB 2JNszEmGTuSU0Bkijejc6MqBCYEuiRv3L9ian7ERiodL6qaMRILL3ZVHUXTq/qy90S3U XwzLAQwBf6l/8EhBi+0vMmn1186V+g36YuDIz3VYjfTUaJRTDphMt/4K1uhnEUA4EY96 yD4y2ip9tqNpGU93JKnMS2zoA3uN3x3e3d5MkEWQv1WGy26+qoneTA8ADmrSWeLFLxH9 kq7J0UVAMd6bXc7N3NB/GEBdFYnUe52ITk++AKSZBw1csAyaV/4XlyEfw/EPlH903taY PgGA== X-Gm-Message-State: AMke39l8GkmG72rdQYccBr4rrQeHsG34i10j16jaNDuFhivVuRyPxVf6eLIv/tzBX15Ibg== X-Received: by 10.46.20.27 with SMTP id u27mr5853399ljd.103.1488826360606; Mon, 06 Mar 2017 10:52:40 -0800 (PST) Received: from spectre.mavhome.dp.ua ([134.249.139.101]) by smtp.gmail.com with ESMTPSA id p27sm2354409lfg.5.2017.03.06.10.52.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 10:52:39 -0800 (PST) Sender: Alexander Motin Subject: Re: 11-STABLE vs 11.0-RELENG test To: Matthew Ahrens References: <8b4ba98d-03d3-f671-33b2-ed12d3b4fb7c@FreeBSD.org> <374b6d16-5cb4-9338-ec1d-65ad93ca29dc@FreeBSD.org> Cc: freebsd-fs , Andriy Gapon From: Alexander Motin Message-ID: Date: Mon, 6 Mar 2017 20:52:38 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 18:52:42 -0000 On 06.03.2017 20:11, Matthew Ahrens wrote: > FYI - I am changing this sorting to be based on the bookmark (objset, > object, level, blkid) instead of timestamp. This normally doesn't > change the performance on illumos, but it should fix this on FreeBSD > (and it ensures that the multi-threaded spa_sync doesn't degrade > performance). > > Here's the PR; you can pick out the "sort by bookmark" commit if you want: > > https://github.com/openzfs/openzfs/pull/138 Thank you for the notice, but we already have alike patch in a tree for few months to address the mentioned issue: https://svnweb.freebsd.org/base?view=revision&revision=309714 We'll just replace one patch with another when yours comes in to reduce the code divergence. -- Alexander Motin