From nobody Mon Jun 1 07:38:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gTQmj0MXjz6gcyH; Mon, 01 Jun 2026 07:38:13 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gTQmh6wqpz4Bt0; Mon, 01 Jun 2026 07:38:12 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780299493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zpssdGiAS9cLHlpblqu/YgKPboCZfieicljN9f/8LhM=; b=woHFpcDgOWTfqvDT3T96Bq7ue1s7uTUvsCPTld70xtHstRcj4m45jFDxdANOS6UjzWYcgV 1vYS1BUlF2cRsIAgbyqDFE10bLjQOmHeJSIBqZ6QlD/o2XvfPG3iwyx9ZFnGLaf8NR7qh8 5TyewbVMaRUjSuE713h35Z9SlMxCdJ5WOHJAozROse1X0JdLAUCqDzo46zsQ4SSH/9qLpx GR6nR/UyIBImOx2DhfHF+uEEuiNlGHvhU1YSztn29h5rxWO0a4rWpuix/fgNHNSLKx504P Do+k41GDGdfmjrBBmQ/TfvCmupoBqmUknZAtfWjZo7EvXGRr1hF0OlOKK30WvA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780299493; a=rsa-sha256; cv=none; b=mj8xRNuj5M3OciFuAskbDgNdqFiFVsgt/lscf2ivtIVMXWJQVa/iWgmT+PVSHE+AaSY/x2 VSuEt34zUaDGHQ/aaCJSD3gtofbqxMWcaQq6mV1fZhBH7Asvhjt97MkXYEq/V/GLc/qyjW jBYr0YKU9mor8l/8/Qsh+tu2d/c6WlbRJMQ15RV6MXg1lmcoaP4+R6yMROQtYdA49jqEX+ Ep7/IarZvWaEEX5HETXqcGv7KWLN5TnY5/nKcu16m06ue0DRh5seuwBghTWSazT9kryXaM XzYJjVR6+A/1x0Pc+KMsH5quwBYwyD+MImr35NgUu1Y/hL4bMZQotpOysRnv7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780299493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zpssdGiAS9cLHlpblqu/YgKPboCZfieicljN9f/8LhM=; b=SuEC4R9L8npVzMeY9eoxvYjefypY7HppK30BYDHZ9HeWukLB1RhTsSITFOWWiRfE/jgV3l vXZGffimULZaJKSXf/M66THE+pO1Ypvz4Y0jZ8aIvjNv1L347y5NvgLfN/awcklkCpkiS/ +SBkHjzTYl7X+TOGe9gKXw1v8bS/ISEe1sdAh1I5GcKqyLZ2QutosBET/kdEOX1As5tdNO UkV23nMGaHOA/vgzh+fDybPORjtxmz8p1LCxNB6xWM2/6BGaSu/Xer8Kt6FLj8Z2cLLzEx DBjBe5Pjidi4rrV6KVcjr0FehcBSc/7OA44OD6Ayqv6VwU+eWM2L3Rxh+aWOJQ== Received: from ravel.localnet (lfbn-nic-1-328-19.w90-116.abo.wanadoo.fr [90.116.162.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gTQmh0hgyz199; Mon, 01 Jun 2026 07:38:11 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Robert Clausecker Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org, Konstantin Belousov Subject: Re: git: 439710cf003b - main - assert.h: Revert "Remove leading tabs for whitespace consistency" Date: Mon, 01 Jun 2026 09:38:04 +0200 Message-ID: <2528022.THHZn3L5Ee@ravel> In-Reply-To: <6a1c9142.3037a.348e36a2@gitrepo.freebsd.org> References: <6a1c9142.3037a.348e36a2@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4178553.kAAoriTUSa"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart4178553.kAAoriTUSa Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner To: Robert Clausecker Date: Mon, 01 Jun 2026 09:38:04 +0200 Message-ID: <2528022.THHZn3L5Ee@ravel> In-Reply-To: <6a1c9142.3037a.348e36a2@gitrepo.freebsd.org> References: <6a1c9142.3037a.348e36a2@gitrepo.freebsd.org> MIME-Version: 1.0 Hi Robert, > As per style(9), a tab goes after #define. This should not have been > removed. A TAB or space indifferently can go after a '#define', the important thing is whitespace consistency. To quote style(9): "Put a single space or tab character between the #define and the macro name, but be consistent within a file.". Here, although not covered explicitly by style(9), there's still a series of '#undef' that does not have a TAB after it but a space. Additionally, from style(9): "The comment should be separated from the #endif or #else by a single space." speaking about comments matching (the invert of) '#if" conditions, so ruling out TABs there. All-in-all, the original commit was fine and IMO should not have been reverted. Thanks and regards. -- Olivier Certner --nextPart4178553.kAAoriTUSa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmodNtwACgkQjKEwQJce JiedjQ/9HjFPytY2e+/9Dd+MKqKHS0jNMwiCdz2O5ovx2EYkzdcHv4RzCN0nYZKa hmBWUkgv0+qWWe1tZGEnJDGv9KIecA8Empk5++mWHYmKHSl2OsXasg/tnNPhBenq rLDsmS1HCzpmSBcG49ajTt8tHzw0yjr085S7fvD/9Bcvl5d8QzJBYdJ+FtHcm8MF iRduU+bjpTRYANV9oWFDVKTyZavKFH1kAYWY3u6f2rE6b0Igsj4jPNfQl6uxxFkJ aMHNmr75Iinq/Ioayj2XHM2z5ZflnO4DmvXANkS64CD1Z5SrWU1HGBz7h1zcfPsI VHxtPQrCl53JmN6AFinrtAJ1J8YUEBXzL+zSy330njgPP6Und4/QrO8Ix2LVMo0C n5cbnLZ0N7T69lHnaWW+XywsVyZkf2zCdhE3eBTWWUYIpOx8VYBsuHNwD5aH1nCI Tp/YF9Vv5b+3yukCbe3Ga0/AuNyM2MPVlB4y0eFBppZ+jCfxuHAjEk1wAsVvCTm/ KP7J4fO8slovhyKmbBk0g5aRGkgrau0Ai8ZJu/xY3TJc2BlVmETtXO3McYK5Pwr9 eMDd90jIdnIpCwfn0bbvKtogI7oXMD6XZ/+zzNvv8NaOeSvUwSF5PpWqqMi7lFaC sR8nnGsbFoUFs6thNA4/5Eiegeuv4lbX5/V9r8lHePUM6nlbXJk= =sRUl -----END PGP SIGNATURE----- --nextPart4178553.kAAoriTUSa--