From owner-svn-src-head@FreeBSD.ORG Sun Jan 15 23:34:46 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C731F1065673 for ; Sun, 15 Jan 2012 23:34:46 +0000 (UTC) (envelope-from bounces+73574-9504-svn-src-head=freebsd.org@sendgrid.me) Received: from o7.shared.sendgrid.net (o7.shared.sendgrid.net [74.63.235.40]) by mx1.freebsd.org (Postfix) with SMTP id 6D4558FC18 for ; Sun, 15 Jan 2012 23:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=d09sZu+YY0b9aypjqRtX5DlEIN8=; b=Dry3NIpA52DaeIWXRAo9/W5Kq+YD kG2qZjk9QS2POGh4Mlust5S43a089ff0M2AUzGuDSFquzvBiTPFMwE991iQESZwz TMTReigOis/nA+AvBOlMlUYaTwtDkIVa89fLu7Jc0LwGSij7g07lIIq7NS9W1a+V nTgu2LdrDumpWTU= Received: by 10.41.149.155 with SMTP id f04-20.11521.4F1362575 Sun, 15 Jan 2012 23:33:43 +0000 (UTC) Received: from mail.tarsnap.com (unknown [10.41.149.212]) by i04-04 (SG) with ESMTP id 4f13608a.3ac2.2a5b9e7 for ; Sun, 15 Jan 2012 23:26:02 +0000 (UTC) Received: (qmail 56324 invoked from network); 15 Jan 2012 23:33:02 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by mail.tarsnap.com with ESMTP; 15 Jan 2012 23:33:02 -0000 Received: (qmail 75936 invoked from network); 15 Jan 2012 23:32:43 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 15 Jan 2012 23:32:43 -0000 Message-ID: <4F13621B.1060203@freebsd.org> Date: Sun, 15 Jan 2012 15:32:43 -0800 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111112 Thunderbird/8.0 MIME-Version: 1.0 To: John Baldwin References: <201201150709.q0F79Iif067938@svn.freebsd.org> <4F136109.9050004@FreeBSD.org> In-Reply-To: <4F136109.9050004@FreeBSD.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: EvYvoie/qnEezyq2t4eRKjDm9X7ZKbCMt75WvXA+XNGk/e+ljQsb4EH2uBW+cVj3VR4rJRvePKmGeFllO+nUeimhbIDAtBiMrIENycLgAIoZsmB1UZgFslewEFWJ+XGdoLtUb5OBKHX2j66sjXH2Rccb2JiCHD8J7AbJg4UaUYw= Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler Subject: Re: svn commit: r230125 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 23:34:46 -0000 On 01/15/12 15:28, John Baldwin wrote: > On 1/15/12 2:09 AM, Eitan Adler wrote: >> Log: >> - Fix undefined behavior when device_get_name is null >> - Make error message more informative > > The in-kernel printf(9) always prints "(null)" for %s when the pointer is NULL, > so that wasn't undefined behavior. Printing out the driver name is a useful > change, but the "(unknown)" bits are just noise as it isn't clear that > "(unknown)" is substantially better than "(null)". I think the change from "(null)" to "(unknown)" is useful, since when I see "(null)" printed my immediate thought is "looks like there's a bug I need to track down here". -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid