From owner-svn-src-head@freebsd.org Sat Aug 18 05:35:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E12BD1086783; Sat, 18 Aug 2018 05:35:52 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5A20082EE9; Sat, 18 Aug 2018 05:35:52 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w7I5Zf3Z062953; Fri, 17 Aug 2018 22:35:41 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w7I5ZfsS062952; Fri, 17 Aug 2018 22:35:41 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201808180535.w7I5ZfsS062952@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r337956 - in head: . bin/ls In-Reply-To: <201808171549.w7HFndsp059932@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org Date: Fri, 17 Aug 2018 22:35:41 -0700 (PDT) CC: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Aug 2018 05:35:53 -0000 > > On Fri, Aug 17, 2018 at 10:26 AM, Kyle Evans wrote: > > > On Fri, Aug 17, 2018 at 10:24 AM, Rodney W. Grimes > > > wrote: > > >>> Author: kevans > > >>> Date: Fri Aug 17 04:15:51 2018 > > >>> New Revision: 337956 > > >>> URL: https://svnweb.freebsd.org/changeset/base/337956 > > >>> > > >>> Log: > > >>> ls(1): Add --color=when > > >>> > > >>> --color may be set to one of: 'auto', 'always', and 'never'. > > >>> > > >>> 'auto' is the default behavior- output colors only if -G or COLORTERM are > > >> > > >> Why different than coreutils ls? Default for coreutils is none. > > > > > > I guess this was worded poorly and you skipped both the review and > > > reading the diff... this is still contingent on environment variables > > > or -G being specified. > > > > > >>> set, and only if stdout is a tty. > > >>> > > >>> 'always' is a new behavior- output colors always. termcap(5) will be > > >>> consulted unless TERM is unset or not a recognized terminal, in which case > > >>> ls(1) will fall back to explicitly outputting ANSI escape sequences. > > >>> > > >>> 'never' to turn off any environment variable and -G usage. > > >> Why different than core utils? Coreutils uses none. > > > > > > I guess this was worded poorly and you skipped both the review and > > > reading the diff... this is still contingent on environment variables > > > or -G being specified. > > > > > > > ... copy-paste-o. The version of coreutils ls(1) that I have uses > > 'never' for this. There is no valid 'none' value. > > Oh boy, we need to investiage that then, cause it seems > as if the official page says none. Does your say it > has a different default value too? And our package of gnu coreutils also says never, so ignore my raising the issue of none vs never, that needs to be raised with the gnu folks as it seems as if there online manual and the code is in conflict. Ooopss.. retract that here we go... I have our pkg coreutils installed: root@x230a:~ # gls --color=none 828phone.tgz Desktop Downloads firefox.core soffice.bin.core root@x230a:~ # gls --color=never 828phone.tgz Desktop Downloads firefox.core soffice.bin.core root@x230a:~ # gls --color=theychangedit gls: invalid argument 'theychangedit' for '--color' Valid arguments are: - 'always', 'yes', 'force' - 'never', 'no', 'none' - 'auto', 'tty', 'if-tty' Try 'gls --help' for more information. So it looks as if we need to add a we bit more to make our use of --color match what coreutils actually allows. *Runs and ducks* cause Kyle has already gone way above the call of duty on this one! -- Rod Grimes rgrimes@freebsd.org