From owner-cvs-all Mon Jan 28 0:29:18 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id 0915837B404; Mon, 28 Jan 2002 00:29:09 -0800 (PST) Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020128082908.UZWR10199.rwcrmhc53.attbi.com@peter3.wemm.org>; Mon, 28 Jan 2002 08:29:08 +0000 Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g0S8T8s39719; Mon, 28 Jan 2002 00:29:08 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 310643BAC; Mon, 28 Jan 2002 00:29:08 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Greg Lehey Cc: Kris Kennaway , Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssl/crypto/evp evp.h src/crypto/openssl/crypto/rsa rsa.h rsa_eay.c src/crypto/openssl/ssl s23_clnt.c s23_srvr.c s2_clnt.c s2_enc.c s2_pkt.c s2_srvr.c In-Reply-To: <20020128131535.L18585@wantadilla.lemis.com> Date: Mon, 28 Jan 2002 00:29:08 -0800 From: Peter Wemm Message-Id: <20020128082908.310643BAC@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Greg Lehey wrote: > On Sunday, 27 January 2002 at 17:33:57 -0800, Kris Kennaway wrote: > > On Mon, Jan 28, 2002 at 10:48:07AM +1030, Greg Lehey wrote: > >> On Saturday, 26 January 2002 at 19:17:13 -0800, Kris Kennaway wrote: > >>> kris 2002/01/26 19:17:13 PST > >>> > >>> Modified files: > >>> crypto/openssl/crypto/evp evp.h > >>> crypto/openssl/crypto/rsa rsa.h rsa_eay.c > >>> crypto/openssl/ssl s23_clnt.c s23_srvr.c s2_clnt.c s2_enc.c > >>> s2_pkt.c s2_srvr.c > >>> Log: > >>> Resolve conflicts. > >>> > >>> Revision Changes Path > >>> 1.9 +2 -4 src/crypto/openssl/crypto/evp/evp.h > >>> 1.7 +3 -4 src/crypto/openssl/crypto/rsa/rsa.h > >>> 1.7 +32 -3 src/crypto/openssl/crypto/rsa/rsa_eay.c > >>> 1.6 +2 -2 src/crypto/openssl/ssl/s23_clnt.c > >>> 1.6 +81 -12 src/crypto/openssl/ssl/s23_srvr.c > >>> 1.7 +89 -22 src/crypto/openssl/ssl/s2_clnt.c > >>> 1.6 +3 -3 src/crypto/openssl/ssl/s2_enc.c > >>> 1.7 +38 -21 src/crypto/openssl/ssl/s2_pkt.c > >>> 1.7 +120 -22 src/crypto/openssl/ssl/s2_srvr.c > >> > >> That's a lot of conflicts. Some of them appear to be added copyright > >> notices and some code changes which aren't immediately apparent, but > >> don't look much like conflicts to me. Can't we have a more > >> descriptive log message? > > > > You seem to ask for this a lot; I don't think you understand the cvs > > import process. > > Maybe I don't. Was there something here which I should have noticed > which shows that these were import conflicts? Most of the messages of > this nature don't seem to be, which is why I pick on them. Well, a better commit message may be "merge vendor changes onto mainline", which is exactly accurate. Or even "merge vendor changes between foo-release and bar-release onto mainline". There's not really anything more to be said. When you do an import, some files immediately have the changes visible, and some require a manual merge like this. It sucks that imports are not atomic or coherent, but that's the way cvs is. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message