From owner-cvs-src@FreeBSD.ORG Tue May 13 08:09:14 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC0A137B401; Tue, 13 May 2003 08:09:13 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6621543F3F; Tue, 13 May 2003 08:09:10 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id BD52C530E; Tue, 13 May 2003 17:09:07 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "M. Warner Losh" References: <20030512.223927.39164038.imp@bsdimp.com> <20030513.083546.133906327.imp@bsdimp.com> From: Dag-Erling Smorgrav Date: Tue, 13 May 2003 17:09:06 +0200 In-Reply-To: <20030513.083546.133906327.imp@bsdimp.com> (M. Warner Losh's message of "Tue, 13 May 2003 08:35:46 -0600 (MDT)") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii cc: joe@FreeBSD.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: obrien@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2003 15:09:14 -0000 "M. Warner Losh" writes: > The makefiles for the modules still need to be included. No, the kernel and modules build fine with these two patches, there is no need to change the module Makefiles (they already contain an explicit dependency on opt_usb.h which triggers the dependency on usbdevs.h in kmod.mk). But I much prefer the solution you posted on -arch. In any case, this can (and should) wait until after 5.1. DES -- Dag-Erling Smorgrav - des@ofug.org