From owner-svn-src-head@freebsd.org Mon Aug 15 19:56:49 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C583BBB72B; Mon, 15 Aug 2016 19:56:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1D80E1DCE; Mon, 15 Aug 2016 19:56:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u7FJuiZm062107 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 15 Aug 2016 22:56:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u7FJuiZm062107 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u7FJuiPI062106; Mon, 15 Aug 2016 22:56:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 15 Aug 2016 22:56:44 +0300 From: Konstantin Belousov To: Ed Schouten Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304182 - head/sys/compat/cloudabi Message-ID: <20160815195644.GC83214@kib.kiev.ua> References: <201608151942.u7FJgL99007373@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201608151942.u7FJgL99007373@repo.freebsd.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2016 19:56:49 -0000 On Mon, Aug 15, 2016 at 07:42:21PM +0000, Ed Schouten wrote: > Author: ed > Date: Mon Aug 15 19:42:21 2016 > New Revision: 304182 > URL: https://svnweb.freebsd.org/changeset/base/304182 > > Log: > Let CloudABI use fdatasync() as well. > > Now that FreeBSD supports fdatasync() natively, we can tidy up > CloudABI's equivalent system call to use that instead. > > Modified: > head/sys/compat/cloudabi/cloudabi_fd.c > > Modified: head/sys/compat/cloudabi/cloudabi_fd.c > ============================================================================== > --- head/sys/compat/cloudabi/cloudabi_fd.c Mon Aug 15 19:37:18 2016 (r304181) > +++ head/sys/compat/cloudabi/cloudabi_fd.c Mon Aug 15 19:42:21 2016 (r304182) > @@ -172,12 +172,11 @@ int > cloudabi_sys_fd_datasync(struct thread *td, > struct cloudabi_sys_fd_datasync_args *uap) > { > - struct fsync_args fsync_args = { > + struct fdatasync_args fdatasync_args = { > .fd = uap->fd > }; > > - /* Call into fsync(), as FreeBSD lacks fdatasync(). */ > - return (sys_fsync(td, &fsync_args)); > + return (sys_fdatasync(td, &fdatasync_args)); > } > Please make kern_fsync() non-static and use it instead of providing fake fdatasync_args structure.