Date: Sun, 10 Apr 2016 01:29:12 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 206771] games/taipan: Subscript out of bounds. Message-ID: <bug-206771-13-WfVEvd7Yr5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-206771-13@https.bugs.freebsd.org/bugzilla/> References: <bug-206771-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206771 Jason Unovitch <junovitch@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |junovitch@freebsd.org Resolution|--- |FIXED Assignee|freebsd-ports-bugs@FreeBSD. |junovitch@freebsd.org |org | Flags| |merge-quarterly+ Status|New |Closed --- Comment #15 from Jason Unovitch <junovitch@freebsd.org> --- Both GCC and Clang will warn when compiling outside of the ports collection= so I just added this as is without any LICENSE changes and MFH'd this as a fix. David, thank you for the report! Christoph, thanks for the patch! Technically PR patches would normally be generated from doing something along the lines of `cd /usr/ports/games/taip= an; svn diff > ~/taipain.patch`. You attached just the patch-taipan.c file. T= hat was fine in this simple case as it just replaced the existing patch-taipan.c file and at a minimal required a PORTREVISION bump to the Makefile. That's easy enough for me to do pre-commit but keep this in mind and take a look at the helpful guidance in the Porter's Handbook next time. [1] [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/ --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206771-13-WfVEvd7Yr5>