From owner-svn-src-head@freebsd.org  Tue Jun 26 05:21:29 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7793B100FB92;
 Tue, 26 Jun 2018 05:21:29 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0AD667FC44;
 Tue, 26 Jun 2018 05:21:28 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id E92241E46; Tue, 26 Jun 2018 05:21:27 +0000 (UTC)
Date: Tue, 26 Jun 2018 05:21:27 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: rgrimes@freebsd.org
Cc: Roger Pau Monn?? <royger@freebsd.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga
Message-ID: <20180626052127.GA19828@FreeBSD.org>
References: <201806250939.w5P9dGMA067104@repo.freebsd.org>
 <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 05:21:29 -0000

On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote:
> > New Revision: 335629
> > URL: https://svnweb.freebsd.org/changeset/base/335629
> > 
> > Log:
> >   vt: add option to ignore NO_VGA flag in ACPI
> >   
> >   To workaround buggy firmware that sets this flag when there's actually
> >   a VGA present.
> >   
> >   Reported and tested by:	Yasuhiro KIMURA <yasu@utahime.org>
> >   Sponsored by:		Citrix Systems R&D
> >   Reviewed by:		kib
> >   Differential revision:	https://reviews.freebsd.org/D16003
> 
> It is generally best to avoid double negatives,
> couldnt this of been better named? (hw.vga.acpi_force_vga)

Yes please; I get constantly confused when calculating negatives and
often get them wrong.

./danfe