From owner-freebsd-git@freebsd.org Mon Nov 30 18:52:45 2020 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 81D904A54DE for ; Mon, 30 Nov 2020 18:52:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4ClDrF1qDrz4XRh for ; Mon, 30 Nov 2020 18:52:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 3E30D4A5339; Mon, 30 Nov 2020 18:52:45 +0000 (UTC) Delivered-To: git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3DCC94A53B0 for ; Mon, 30 Nov 2020 18:52:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ClDrF0nYLz4XLq for ; Mon, 30 Nov 2020 18:52:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x830.google.com with SMTP id k4so4284039qtj.10 for ; Mon, 30 Nov 2020 10:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jz5p7i8hpbM2ybebcF+vVXplIje5rM3OWkLbRe7GECI=; b=kisoqMRT9Ob+pCOhNxG8Q0nOuNoq+wqdjGgL3w7PvckqOGQRhlx2HWe+kC1FK1eDLD FciD8yirrfRUmhTmYCOty37PRRbYsgIfhF+LcbhoGh++sM0mbgp6Mw9MnJPkbzaRSwpz 1mstVI2Hy4aDxs5LS6sG0wMG5j4P2tKe3yKVS0/Ke9ZCb79H6u3uu3cAruaZHzgIBIqI BeY+RqgI1D80YFC/40cB03BAARYM+gw1aDgHYIGgZFYyfNR0vPhsVuiBnrQSbTaDi89U LuXVRbWDzPvbdZFq0ujUNylZ0pM2SPrO+0eeKx+1ZSKnE9dXpJ+yWcPC1DT31Ym9BtQr ZNxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jz5p7i8hpbM2ybebcF+vVXplIje5rM3OWkLbRe7GECI=; b=BV9vsBbb7mv1fX/tcNNC+4KdBUXTyzLtrBy/K/Ad1O4E6JhAHJE8npNIDl61dwBIkO lg0s/zay/4eoM8MGyJsCpzTj/u6xzQDx4iP4hBQsWJ2zQC1Q5b+LVe+IE5XXLbe++R7d zp4z3wKD/3A9wM29oV/oLYLXcjgVQLxhA8cqIK+rNG7XXxmCXt0HT9sg/SXmiGKxPo5Y vMRH7xiviO/m9QR80wF1r6qbX0p9uh29lEZpbksQL5e7WEwsnObRKCf4nw3fc6GydO+m e0xL7mDjB9PXbtKvqi0aU191stA29nzR4MhN+47YlDm9hZ1U6RzJcIGm1CmxaANVCe1+ GWwQ== X-Gm-Message-State: AOAM530H9smVz1K7QUW393836u9bY+kBZVlf/c5mi26XJkTLPvFlOO1F tFz/V8bPSmkLU1CFgTAznWhJ37eA0eCdmeLPCmyHEw== X-Google-Smtp-Source: ABdhPJzBCxyITl+KI0PHQokRavfgYJSFx6P+pQIecetwjn2BRM/ny+QluyTrUfQMiDYyklFwoIXTHxK6lbFPxH3KvLM= X-Received: by 2002:ac8:4802:: with SMTP id g2mr23191363qtq.235.1606762363826; Mon, 30 Nov 2020 10:52:43 -0800 (PST) MIME-Version: 1.0 References: <20201129164707.GA31739@freefall.freebsd.org> <14871125-A032-4980-8DB1-0210E34D5A11@FreeBSD.org> <20201130105337.GA42359@freefall.freebsd.org> <20201130115743.elfr6y2anpuoh5gy@aching.in.mat.cc> In-Reply-To: <20201130115743.elfr6y2anpuoh5gy@aching.in.mat.cc> From: Warner Losh Date: Mon, 30 Nov 2020 11:52:32 -0700 Message-ID: Subject: Re: converting rmport to git To: Mathieu Arnold Cc: Rene Ladan , Chris Rees , Adam Weinberger , git@freebsd.org, "portmgr@FreeBSD.org" X-Rspamd-Queue-Id: 4ClDrF0nYLz4XLq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 18:52:45 -0000 On Mon, Nov 30, 2020 at 4:57 AM Mathieu Arnold wrote: > On Mon, Nov 30, 2020 at 10:53:37AM +0000, Rene Ladan wrote: > > OK, I'll rewrite the script to use the branch workflow. This does assume > > having an existing clone of the git repository present, but I guess that > > is a safe assumption if you are a ports committer :) > > You really should not to worry about branches, the script could emit a > warning if it runs on the default branch, which will be something like > "main" but the script should not worry about all that, it should just > assume it has the checkout of the thing you need to remove ports from, > let the user worry about working on some branch or not. > A clean tree is the only real requirement, and all you need to check for / assume. However, it would be nice to allow for the steps to create a branch and/or worktree, if desired. There are times you'd want to run this in a mode that just does it and then you push. And there's times you need to run more extensive testing / regression. Automating the branching dance would allow for that. Making it optional would address the likely more typical case of 'I just want to remove this port'. Warner