From owner-svn-src-head@freebsd.org Tue Apr 25 18:33:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F2B5D503A3; Tue, 25 Apr 2017 18:33:40 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi0-x22b.google.com (mail-oi0-x22b.google.com [IPv6:2607:f8b0:4003:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D767737D; Tue, 25 Apr 2017 18:33:39 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi0-x22b.google.com with SMTP id x184so183325039oia.1; Tue, 25 Apr 2017 11:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xUQUCUm9zYbvKUA9mU1Q+KKv7NRdkP4b3Oy3MvetNvQ=; b=kQWdp1mFma+40vVNHtIVQBnCc4p06EQnVTH6zb4Z2cagdkz8wUZD+Bbp+qKI72aYXH 7jmi9Yd/2X9PDX26U8vWbpJK1EfiJBXAHvBqCAfVEM1P95jhQRNfBC+Lx1k7pC+7okkv 51Jm+8g7zNr8k0X6Mvg9A6aiuSkCgeLE69wNpd9Z2ItUTu+wyCofiUY1BX/rz1bADqu0 3/1LBpeJ/5IErHKRCLJ/TvAeSfDS/xlUVTq49F48JEkabynalkc7h1dBmqRgxYnYAb4w DbS8i7mejT7IlPHJeD5XWoFGQqFVdACDmcqMjZWtEOMfmXcv/rgKrIeSaawWVpT71hdZ 9gJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xUQUCUm9zYbvKUA9mU1Q+KKv7NRdkP4b3Oy3MvetNvQ=; b=o1+5KVynUyAo2oUJ8N5UbfDFy0fzpA9MTyRv2WQP1VfstP/ckF+U5loQsLNCBDzAP4 0D0gEUeoqnmM4QZe7FQzBtQsuu/CO+w4dzUGwM3eeOon4t/VUocpJCqdlFrnV8SfwsMP 7aqltctMCE2gYlMRJ63UH+P4VrsX5E4adp1LaG1ruwAmtkWPAQhOqsrz7HQgigzJUjvM 1a8hcn+xNyylIlADH9ryl9AjXgndItnB5bTAXvNh1jZa1oxn5fHqmLsiQNxoZg+zvzbz 5EpGwfXA0xfK6wz3V9T0E6Cpx5denpShK2zCF79jWUgzTz13lvzYaaz016CNoC4agJxZ OJ9g== X-Gm-Message-State: AN3rC/5d6XXft8nuZvati1EFKwULYGC+OEgG9Vein62FJ4izN4oepbNB /51jWP/PRwsDIYz8dncDvQcWMfpCgQ== X-Received: by 10.157.2.101 with SMTP id 92mr20463985otb.52.1493145219097; Tue, 25 Apr 2017 11:33:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.50.133 with HTTP; Tue, 25 Apr 2017 11:33:38 -0700 (PDT) In-Reply-To: <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net> References: <201704251556.v3PFuk5U053547@repo.freebsd.org> <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net> From: Benjamin Kaduk Date: Tue, 25 Apr 2017 13:33:38 -0500 Message-ID: Subject: Re: svn commit: r317409 - head/contrib/tcpdump To: rgrimes@freebsd.org Cc: Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 18:33:40 -0000 On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: glebius > > Date: Tue Apr 25 15:56:46 2017 > > New Revision: 317409 > > URL: https://svnweb.freebsd.org/changeset/base/317409 > > > > Log: > > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use > after free > > Lets not use git hashes as references in commit messages, > it has very little value for someone reading a log of changes > looking for something. There is no promise that it can be > found later (github can go Poof). > On the contrary, a git SHA1 seems like an eminently stable and unique search parameter! I agree that a commit log should inline some summary of the change as well as provide a link to the external source, but I am not worried that a future reader will be unable to find the referenced commit. -Ben