Date: Wed, 6 May 2020 16:40:56 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "Conrad E. Meyer" <cem@freebsd.org> Subject: Re: svn commit: r533459 - head/Mk/Scripts Message-ID: <20200506144056.rtx2oygw73qq7rsw@aching.in.mat.cc> In-Reply-To: <276aef88-4619-b4b7-ee92-44999b5c787d@FreeBSD.org> References: <202004301448.03UEmMwc053196@repo.freebsd.org> <276aef88-4619-b4b7-ee92-44999b5c787d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i6qhj2h5tqsdcwds Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 04, 2020 at 10:49:34AM -0700, Bryan Drewery wrote: > On 4/30/2020 7:48 AM, Mathieu Arnold wrote: > > Author: mat > > Date: Thu Apr 30 14:48:22 2020 > > New Revision: 533459 > > URL: https://svnweb.freebsd.org/changeset/ports/533459 > >=20 > > Log: > > When one patch fails, continue with appling patches. > > =20 > > This makes the process of make patch, fix fallout, make makepatch much > > easier as only one iteration is required. > > =20 > > While there, refactor things around, and streamline messages passed > > between functions. > > =20 > > PR: 244626 > > Reported by: cem > >=20 >=20 > Will this fail between stages? If a files/patch-* patch fails it should > not move on to extra patches as then makepatch / diffing will be wrong. > Even patch-* can lead to being wrong when considering local (not in > ports tree) patches. >=20 > I don't think this is good default behavior. No, it will try to apply all patches, and report all the failures. I am not sure where you are getting at. If you run `make patch; make makepatch` the usage would have been broken before and still is. If you run `make patch makepatch`, the usage does not change, if patching fails, it does not go into makepatch target, and if patching is ok, then makepatch runs and updates your patches. --=20 Mathieu Arnold --i6qhj2h5tqsdcwds Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl6yzHNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgLDJxAAifPWYJyQu9UOnAsa6S5E+KDCYIuUUf/b3m+q5Ez3OJ1GKWDM7N0Bwt4W Cat5OpLe8S/IaC7h7cgcFLRKhrTyuQw9KpUE6edfdw6ulBRAqcEzfEmEZgvwXN20 9ZG03IHebkwdcam/sPyQTxAXL/L4h+EfaWfMQVuPlvYz8Em7SRu1d0uCoRWC07jt abbf4I4Us2N8YHm4YcObBY48XrPXzvEx0TIVnP3ySamm2PcUgyPHID/GPL4EYlXK kHCKisnAsV9u8zcs87QxZCN1DnvHhSHgdCpLC2Tj1m+quV2osKXrFmvRXcvqMfe1 cm35bXz1rcFTjrjc0mEp6kMr09XZkMWuL8R7YA1piTOvoDroHwAOmrGltlSuydkm 8WdoIOHVoRkQV1TjMTFMrjLFW1Aj9et1F9wJOJEyVA4VJgHV02pWdh54KAG5dOik EjRYgvq+mW/dWHRh/P1cF1CoWBLvY+WiaP/iz3FTB2djDAVsHFlvPd1zeHyub2gY W3YJJr90xMR3NuKlh8NcudK9Yd+KH3vSU7lgtZCMGAvkPL6htz0v6FlOBUBbxV4N sp1EzbaMGwh0/Wv7M461vJt7/Zi8dO0ACLDpsG9KqBX9mlD1XSsibeefkoPO+D6U nu8NkzYPo9dqR/nmMJkHr5FgDB7Z3Pte7wEpFXNYSSNu3IXColM= =ash1 -----END PGP SIGNATURE----- --i6qhj2h5tqsdcwds--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200506144056.rtx2oygw73qq7rsw>