From owner-svn-ports-head@FreeBSD.ORG Wed Nov 6 07:19:40 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4631899E for ; Wed, 6 Nov 2013 07:19:40 +0000 (UTC) (envelope-from bounces+73574-c70f-svn-ports-head=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id D0ABF274E for ; Wed, 6 Nov 2013 07:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=ptezHE7PygjHEBe0wliZ7u+ojD4=; b=iqHSvu8r1QWekek77/ JVFVEdePLy4riDICUKfJrMdIOjdsVCYPdjFXnSyXUmUB9v5Mp6zTp0znk+oqqyNt 6ObrFKL4a9a8i9WFGfRDMaB0n1ZTjWByN9mSHga5XXc4rNL8G+618WXcr3qITa15 jq+xvm6b5ccMrmxrFz7byXvqE= Received: by mf27.sendgrid.net with SMTP id mf27.28050.5279ED8B1 Wed, 06 Nov 2013 07:19:39 +0000 (GMT) Received: from mail.tarsnap.com (unknown [10.60.208.15]) by mi30 (SG) with ESMTP id 1422c47e6b6.1acd.3e17eb for ; Wed, 06 Nov 2013 01:19:38 -0600 (CST) Received: (qmail 55644 invoked from network); 6 Nov 2013 07:19:38 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 6 Nov 2013 07:19:38 -0000 Received: (qmail 40112 invoked from network); 6 Nov 2013 07:17:59 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 6 Nov 2013 07:17:59 -0000 Message-ID: <5279ED27.8050107@freebsd.org> Date: Tue, 05 Nov 2013 23:17:59 -0800 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r332668 - in head/security: . pkesh References: <201311040605.rA465DDm028738@svn.freebsd.org> <20131106071044.GF60770@FreeBSD.org> In-Reply-To: <20131106071044.GF60770@FreeBSD.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SG-EID: RYW4HVJU6vENNcqut+BAw7Dij1RmrEHQZJX8miHAouuk1OJfGyf25ygjN/715GbAGGHrIGyY31nju51mAMTABR1ZRR6n/irMsmUqUtLVBR1Fv1TtCxARy082pXE3uhW48bVYtsqxuOEjCRfDkxjoRiED4CCeSxBD+CPmH72ubWI= Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 07:19:40 -0000 On 11/05/13 23:10, Alexey Dokuchaev wrote: > On Mon, Nov 04, 2013 at 06:05:13AM +0000, Colin Percival wrote: >> +NO_BUILD= YES >> +NO_INSTALL= YES > > In ports world (in constrast with src) these are normally spelled "yes". Yeah, I realized that a few hours later when I added the panicmail port; I figured it wasn't worth going back to fix these in pkesh. >> +PLIST_FILES= bin/pkesh \ >> + %%PORTDOCS%%%%DOCSDIR%%/README >> +PLIST_DIRS= %%DOCSDIR%% > > Using PORTDOCS=README would allow you to 1) get tid of eye-tearing %%'s in > PLIST_FILES and drop PLIST_DIRS. Huh. I was confused by the wiki page https://wiki.freebsd.org/ports/StageDir since it says "Just add the right %%PORTDOCS%% as prefix in your pkg-plist...". >> +do-install: >> + ${INSTALL_SCRIPT} ${WRKSRC}/pkesh.sh ${STAGEDIR}${PREFIX}/bin/pkesh >> + >> +post-install: >> + ${MKDIR} ${STAGEDIR}${DOCSDIR} >> + ${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR} > > You could've simply merged all commands in do-install target. No need for > two of them, really. :-) The aforementioned wiki page says "Directory creation should remain in the post-install: target" so that's what I did... -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid