From owner-freebsd-commit  Fri Dec 15 09:51:33 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA06091
          for freebsd-commit-outgoing; Fri, 15 Dec 1995 09:51:33 -0800 (PST)
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA06075
          for cvs-all-outgoing; Fri, 15 Dec 1995 09:51:25 -0800 (PST)
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA06063
          for cvs-sys-outgoing; Fri, 15 Dec 1995 09:51:20 -0800 (PST)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id JAA06054
          Fri, 15 Dec 1995 09:51:09 -0800 (PST)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id EAA24132; Sat, 16 Dec 1995 04:47:00 +1100
Date: Sat, 16 Dec 1995 04:47:00 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199512151747.EAA24132@godzilla.zeta.org.au>
To: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org,
        peter@freefall.freebsd.org
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c
Sender: owner-commit@FreeBSD.ORG
Precedence: bulk

>peter       95/12/14 19:36:29

>  Modified:    sys/ufs/ffs  ffs_alloc.c
>  Log:
>  Silence a harmless warning...

Please fix problems, not warnings.

Here the problem is that one allocation function returns daddr_t and the
other allocation returns ino_t, and daddr_t (which happens to be long)
is incompatible with ino_t (which happens to be u_long).  Everything,
including the recently restored bogus function pointer cast, happens
to work because daddr_t and ino_t happen to have the same size and there
are apparently no sign extension problems.

The correct fix is probably for all allocation functions to return a
common large enough type (u_long in this case, provided there are no
sign extension problems).

Bruce