From owner-freebsd-ports@FreeBSD.ORG Wed Nov 26 14:40:15 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4AE516A4CE for ; Wed, 26 Nov 2003 14:40:15 -0800 (PST) Received: from ms-smtp-03-eri0.southeast.rr.com (ms-smtp-03-lbl.southeast.rr.com [24.25.9.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99AA743FDF for ; Wed, 26 Nov 2003 14:40:14 -0800 (PST) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (rdu74-159-108.nc.rr.com [24.74.159.108])hAQMe6Fm006995; Wed, 26 Nov 2003 17:40:06 -0500 (EST) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) hAQMd5uY005482; Wed, 26 Nov 2003 17:39:05 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Sergey Matveychuk In-Reply-To: <3FC528AD.2050108@ciam.ru> References: <3FC528AD.2050108@ciam.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-xv5gjJB+2Za6ZpHW1DV9" Organization: FreeBSD, Inc. Message-Id: <1069886409.752.106.camel@gyros> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 26 Nov 2003 17:40:09 -0500 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on creme-brulee.marcuscom.com X-Virus-Scanned: Symantec AntiVirus Scan Engine cc: ports@FreeBSD.org Subject: Re: PORTVERSION and portlint X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2003 22:40:16 -0000 --=-xv5gjJB+2Za6ZpHW1DV9 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2003-11-26 at 17:26, Sergey Matveychuk wrote: > What's wrong with '+' sign in PORTVERSION? > www/apache13+modssl, russian/apache* and dns/bind9-dlz ports use it for=20 > separating port version and module version. I think it's a good practice. The idea is to test for PKGVERSIONs that pkg_version cannot handle.=20 However, the '+' notation seems to be correctly handled by pkg_version on -CURRENT and -STABLE (at least with apache-modssl). >=20 > But portlint marks it as FATAL. May be make a sense this simple patch to=20 > apply? Yeah, this makes sense. Joe >=20 > --- > Sem. >=20 > ______________________________________________________________________ > --- portlint.orig Thu Nov 27 01:22:30 2003 > +++ portlint Thu Nov 27 01:23:04 2003 > @@ -1535,7 +1535,7 @@ > &perror("FATAL: $file: PORTVERSION must be specified"); > } > if ($portversion =3D~ /^pl[0-9]*$/ > - || $portversion =3D~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9]*)*$= /) { > + || $portversion =3D~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9+]*)*= $/) { > print "OK: PORTVERSION \"$portversion\" looks fine.\n" if ($verbose); > } elsif ($portversion =3D~ /^[^\-]*\$[{\(].+[\)}][^\-]*$/) { > &perror("WARN: $file: using variable, \"$portversion\", as version ". --=20 Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-xv5gjJB+2Za6ZpHW1DV9 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQA/xSvJb2iPiv4Uz4cRApdNAJ9ge+gGjN7oB9BmBE5sstO2jILpoQCcDgCJ 4CFmjRoIoYnqPW847gi2Ky8= =EPaU -----END PGP SIGNATURE----- --=-xv5gjJB+2Za6ZpHW1DV9--