From owner-cvs-all@FreeBSD.ORG  Mon Sep 20 00:13:21 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 53EA016A4CE; Mon, 20 Sep 2004 00:13:21 +0000 (GMT)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0882B43D39; Mon, 20 Sep 2004 00:13:21 +0000 (GMT)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id i8K0DHnR003178;
	Sun, 19 Sep 2004 20:13:17 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id i8K0DHbt003177;
	Sun, 19 Sep 2004 20:13:17 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Date: Sun, 19 Sep 2004 20:13:17 -0400
From: David Schultz <das@FreeBSD.ORG>
To: Julian Elischer <julian@elischer.org>
Message-ID: <20040920001317.GA2829@VARK.MIT.EDU>
Mail-Followup-To: Julian Elischer <julian@elischer.org>,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200409191834.i8JIYHXU089517@repoman.freebsd.org>
	<414E0DCA.5090601@elischer.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <414E0DCA.5090601@elischer.org>
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern kern_proc.c kern_switch.c src/sys/sys
	sched.h src/sys/vm vm_glue.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Sep 2004 00:13:21 -0000

On Sun, Sep 19, 2004, Julian Elischer wrote:
> David Schultz wrote:
> >das         2004-09-19 18:34:17 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/kern             kern_proc.c kern_switch.c 
> >    sys/sys              sched.h 
> >    sys/vm               vm_glue.c 
> >  Log:
> >  The zone from which proc structures are allocated is marked
> >  UMA_ZONE_NOFREE to guarantee type stability, so proc_fini() should
> >  never be called.  Move an assertion from proc_fini() to proc_dtor()
> >  and garbage-collect the rest of the unreachable code.  I have retained
> >  vm_proc_dispose(), since I consider its disuse a bug.
> 
> well we do aim to one day remove the requirement for UMA_ZONE_NOFREE.
> In fact I have a gague feeling we mayhave already done so. I think it
> had to do with what page tables the kernel ran on after a thread went away.
> Peter may have a better memory as to why that was required.

We are clearly not there yet for things like p_vmspace.  Look at
sys_process.c or procfs, for instance.  But I don't mind backing
this out if someone is imminently preparing to remove the
requirement.

By the way, it would be great if someone who understands it better
could edit the comments in sys/proc.h to reflect reality,
particularly with respect to the locking model.  Some of it seems
to have rotted.  For example, (l) and (m) are unused and p_stats
looks like it should be (c + j).