From owner-freebsd-ports@FreeBSD.ORG Wed Jul 27 09:55:59 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FDB01065673 for ; Wed, 27 Jul 2011 09:55:59 +0000 (UTC) (envelope-from ttsestt@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1EC318FC14 for ; Wed, 27 Jul 2011 09:55:58 +0000 (UTC) Received: by wwg11 with SMTP id 11so2903413wwg.1 for ; Wed, 27 Jul 2011 02:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Wo1XQQlznKFwzWSnZG5bCzB+Gd0vcB5vcUIjEbRHm2M=; b=tmN6amNBYIHSuUi/AzzGLXXbCUpqRto1/fZJhnOu+zxyJECzmdKAlxAymMo6T3xSl/ Q6O0w4kkaAcLmhEteiUZHfgYzbW1/Lmvj/ogahI6RS4Cqx/Q/8BHhgdfXuvEjvbWBs12 DTad6rR4gUxlPswwus3rjdYTsQ8ZoDhQ1r7Io= Received: by 10.216.74.7 with SMTP id w7mr2369460wed.37.1311760557394; Wed, 27 Jul 2011 02:55:57 -0700 (PDT) Received: from localhost ([208.110.65.123]) by mx.google.com with ESMTPS id r48sm929049weq.2.2011.07.27.02.55.55 (version=SSLv3 cipher=OTHER); Wed, 27 Jul 2011 02:55:56 -0700 (PDT) From: Test Rat To: Anton Shterenlikht References: <20110727082212.GA68537@mech-cluster241.men.bris.ac.uk> Date: Wed, 27 Jul 2011 13:55:48 +0400 In-Reply-To: <20110727082212.GA68537@mech-cluster241.men.bris.ac.uk> (Anton Shterenlikht's message of "Wed, 27 Jul 2011 09:22:12 +0100") Message-ID: <86zkk0dp3v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-ports@freebsd.org Subject: Re: is %%GECKO%% defined anywhere? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2011 09:55:59 -0000 Anton Shterenlikht writes: > # cat /usr/ports/textproc/urlview/files/gecko.sh.in > #! /bin/sh > # $FreeBSD: ports/textproc/urlview/files/gecko.sh.in,v 1.1 2009/11/29 08:24:50 obrien Exp $ > # Launch %%GECKO%% for urlview > URL=$@ > %%GECKO%% -remote "openurl($URL, new-tab)" || %%GECKO%% $URL > # > > which on installation turns into > > # cat /usr/local/bin/gecko.sh > #! /bin/sh > # $FreeBSD: ports/textproc/urlview/files/gecko.sh.in,v 1.1 2009/11/29 08:24:50 obrien Exp $ > # Launch for urlview > URL=$@ > -remote "openurl($URL, new-tab)" || $URL > # > > I cannot find any reference to %%GECKO%% in Mk/* It's pre-processed by sed(1) before being installed, see SUB_LIST. $ make -V SUB_LIST:MGECKO\* GECKO= $ make -V SUB_LIST:MGECKO\* WITH_FIREFOX= GECKO=firefox3 $ make -V SUB_LIST:MGECKO\* WITH_SEAMONKEY= GECKO=seamonkey Here is a bandaid that uses firefox by default. A proper fix would probably involve relying on an environment variable and doing away with gecko.sh to also address ports/152453. %% Index: textproc/urlview/Makefile =================================================================== RCS file: /a/.cvsup/ports/textproc/urlview/Makefile,v retrieving revision 1.33 diff -u -p -r1.33 Makefile --- textproc/urlview/Makefile 2 May 2011 22:05:18 -0000 1.33 +++ textproc/urlview/Makefile 27 Jul 2011 09:32:54 -0000 @@ -25,12 +25,12 @@ MAN1= urlview.1 SUB_FILES= gecko.sh SUB_LIST= GECKO=${GECKO} -.if defined(WITH_FIREFOX) -USE_FIREFOX= 36 -GECKO= firefox3 -.elif defined(WITH_SEAMONKEY) +.if defined(WITH_SEAMONKEY) USE_SEAMONKEY= 20 GECKO= seamonkey +.else +USE_FIREFOX= yes +GECKO= firefox .endif .include %%