From owner-svn-src-head@FreeBSD.ORG Sun Nov 9 09:30:05 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFABC106567C for ; Sun, 9 Nov 2008 09:30:05 +0000 (UTC) (envelope-from rionda@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.233]) by mx1.freebsd.org (Postfix) with ESMTP id 85C0F8FC16 for ; Sun, 9 Nov 2008 09:30:05 +0000 (UTC) (envelope-from rionda@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so1851095rvf.43 for ; Sun, 09 Nov 2008 01:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=m6bDywjpCIaZ144QcIX+FJAMt/EgoB4F5Yl4hfCcP4g=; b=UOoLrHca5qago8S2Hfn0iuNRELr52y7Lo0F0kOYGTDJott3L8cYP659wX78q3IzIx+ q31J+o5P8rzJHWat3RP38/8cNceFuvBMV260rj7CmiqRWZNHQlHdlgU2kMuwLXnS2B2O tqe+o1WhjpuevLKPf2SViD+BoI0NVMAX6qXoU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=w3h1KY1MDJr/K2QmVVc0wN1aYzGPusdqtofC/DE/H07w/ZCCaClOaJ7kItuqinuZ1a x6phPHDOdComDsJ59Prdsfj+saVyi1ArR8Ry2zbQiFBJ0ZZVI7SKcZxsCtt6qr5EubSB hIpTyt3Xu7tJPI65nq6X/YnF/w0SiUSopuCCM= Received: by 10.141.153.17 with SMTP id f17mr2861060rvo.99.1226221635680; Sun, 09 Nov 2008 01:07:15 -0800 (PST) Received: by 10.141.195.9 with HTTP; Sun, 9 Nov 2008 01:07:15 -0800 (PST) Message-ID: Date: Sun, 9 Nov 2008 04:07:15 -0500 From: "Matteo Riondato" Sender: rionda@gmail.com To: "Alexey Dokuchaev" In-Reply-To: <20081109084817.GA23323@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811090734.mA97YBld033553@svn.freebsd.org> <20081109084817.GA23323@FreeBSD.org> X-Google-Sender-Auth: 2215ecc7819451a8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184780 - head/usr.sbin/cron/crontab X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Nov 2008 09:30:06 -0000 On Sun, Nov 9, 2008 at 3:48 AM, Alexey Dokuchaev wrote: > On Sun, Nov 09, 2008 at 07:34:11AM +0000, Matteo Riondato wrote: >> >> +void >> +static remove_tmp(int sig) >> +{ >> + if (tmp_path) { >> + unlink(tmp_path); >> + } >> + exit(ERROR_EXIT); >> +} > > This looks weird: `static' should be on same line as `void' as `static > void' (so ^remove_tmp would match). It will also always exit with > ERROR_EXIT, which does not look right, does it? Sure. I reverted the file back to the previous revision. I got other comments which suggest I should work on a better version of the patch. I'll do it later today... Sorry for the noise. Best regards -- Matteo Riondato FreeBSD Committer (http://www.freebsd.org) G.U.F.I. Staff Member (http://www.gufi.org) FreeSBIE Developer (http://www.freesbie.org)