From owner-svn-src-all@freebsd.org Sun Jul 28 16:27:24 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 38AF7AEFA7; Sun, 28 Jul 2019 16:27:24 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C40A46CCFD; Sun, 28 Jul 2019 16:27:22 +0000 (UTC) (envelope-from zeising+freebsd@daemonic.se) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45xSs52c82z3ktq; Sun, 28 Jul 2019 16:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=daemonic.se; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=20151023; t=1564331240; bh=l0jAwBEAgJ3wpg4pvFEea/Hd 7zjl630f45NkfJORKlc=; b=oOFs4jAiB+QkC7JWI1/+2+SLNWfvE9ERk2HkD8Hb TYgmvJxRKAeADZ3FbaQz9c2+AJUJs38pMy6sufthI823Mi29J5wO5RUA7bmfx46I nnc1zQJmgia1o7ilBt0Catv6HW49hTjzcUV1ltmHAkRdednlaORy2hakE6S0MuUK RHE= X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id pJM3Vn90v0zz; Sun, 28 Jul 2019 16:27:20 +0000 (UTC) Received: from vivi.daemonic.se (vivi.daemonic.se [IPv6:2001:470:dca9:2::4]) by mail.daemonic.se (Postfix) with ESMTPSA id 45xSs26BKVz3ktp; Sun, 28 Jul 2019 16:27:18 +0000 (UTC) Subject: Re: svn commit: r350390 - head/sys/kern To: Alan Somers Cc: src-committers , svn-src-all , svn-src-head References: <201907281607.x6SG7SV3080649@repo.freebsd.org> From: Niclas Zeising Message-ID: <1a4155c0-8c32-7424-9482-0f257b16beac@daemonic.se> Date: Sun, 28 Jul 2019 18:27:14 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C40A46CCFD X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=daemonic.se header.s=20151023 header.b=oOFs4jAi; dmarc=pass (policy=none) header.from=daemonic.se; spf=pass (mx1.freebsd.org: domain of zeising@daemonic.se designates 176.58.89.161 as permitted sender) smtp.mailfrom=zeising@daemonic.se X-Spamd-Result: default: False [-7.70 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[daemonic.se:s=20151023]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-3.73)[ip: (-9.83), ipnet: 176.58.89.0/24(-4.91), asn: 36236(-3.87), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[daemonic.se:+]; MX_GOOD(-0.01)[cached: mail.daemonic.se]; DMARC_POLICY_ALLOW(-0.50)[daemonic.se,none]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US]; TAGGED_FROM(0.00)[freebsd]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2019 16:27:24 -0000 On 2019-07-28 18:14, Alan Somers wrote: > On Sun, Jul 28, 2019 at 10:11 AM Niclas Zeising > wrote: >> >> On 2019-07-28 18:07, Alan Somers wrote: >>> Author: asomers >>> Date: Sun Jul 28 16:07:27 2019 >>> New Revision: 350390 >>> URL: https://svnweb.freebsd.org/changeset/base/350390 >>> >>> Log: >>> Better comments for vlrureclaim >>> >>> MFC after: 2 weeks >>> Sponsored by: The FreeBSD Foundation >>> >>> Modified: >>> head/sys/kern/vfs_subr.c >>> >>> Modified: head/sys/kern/vfs_subr.c >>> ============================================================================== >>> --- head/sys/kern/vfs_subr.c Sun Jul 28 15:20:47 2019 (r350389) >>> +++ head/sys/kern/vfs_subr.c Sun Jul 28 16:07:27 2019 (r350390) >>> @@ -947,9 +947,16 @@ vattr_null(struct vattr *vap) >>> * desirable to reuse such vnodes. These conditions may cause the >>> * number of vnodes to reach some minimum value regardless of what >>> * you set kern.maxvnodes to. Do not set kern.maxvnodes too low. >>> + * >>> + * @param mp Try to reclaim vnodes from this mountpoint >>> + * @param reclaim_nc_src Only reclaim directories with outgoing namecache >>> + * entries if this argument is strue >>> + * @param trigger Only reclaim vnodes with fewer than this many resident >>> + * pages. >>> + * @return The number of vnodes that were reclaimed. >>> */ >>> static int >>> -vlrureclaim(struct mount *mp, int reclaim_nc_src, int trigger) >>> +vlrureclaim(struct mount *mp, bool reclaim_nc_src, int trigger) >>> { >>> struct vnode *vp; >>> int count, done, target; >>> @@ -1238,7 +1245,8 @@ vnlru_proc(void) >>> { >>> struct mount *mp, *nmp; >>> unsigned long onumvnodes; >>> - int done, force, reclaim_nc_src, trigger, usevnodes; >>> + int done, force, trigger, usevnodes; >>> + bool reclaim_nc_src; >>> >>> EVENTHANDLER_REGISTER(shutdown_pre_sync, kproc_shutdown, vnlruproc, >>> SHUTDOWN_PRI_FIRST); >> >> Was this change intended? It's not mentioned in the commit message. >> Thanks! >> Regards >> -- >> Niclas > > Yes, it was intended. Since it makes no difference at runtime, I > thought of the type change as basically being documentation. That's > why I didn't explicitly mention it. Ok! Thank you for the explanation. Regards -- Niclas