From owner-freebsd-hackers@FreeBSD.ORG  Thu Jun 16 21:13:37 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8713316A41C
	for <freebsd-hackers@freebsd.org>; Thu, 16 Jun 2005 21:13:37 +0000 (GMT)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe03.swip.net [212.247.154.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2967443D4C
	for <freebsd-hackers@freebsd.org>; Thu, 16 Jun 2005 21:13:36 +0000 (GMT)
	(envelope-from hselasky@c2i.net)
X-T2-Posting-ID: 2oks0tOpjyiYj2pStoKDXw==
Received: from mp-216-40-128.daxnet.no ([193.216.40.128] verified)
	by mailfe03.swip.net (CommuniGate Pro SMTP 4.3.2)
	with ESMTP id 200838640 for freebsd-hackers@freebsd.org;
	Thu, 16 Jun 2005 22:41:51 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-hackers@freebsd.org
Date: Thu, 16 Jun 2005 22:42:37 +0200
User-Agent: KMail/1.7
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200506162242.38227.hselasky@c2i.net>
Subject: sppp and Giant
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: hselasky@c2i.net
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2005 21:13:37 -0000

Hi,

In some existing code it says:

NET_NEEDS_GIANT("i4b_isppp");

s = splimp();
 
sppp_input(&sc->sc_if, m);
 
splx(s);

I have rewritten that code to use its own mutex, 
but does sppp_input() require Giant to be locked?


Can I remove "NET_NEEDS_GIANT(..)" if my "if_start" callback
does not require Giant to be locked?


--HPS