From owner-freebsd-net@FreeBSD.ORG Sat Jun 13 07:58:42 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76FB91065674; Sat, 13 Jun 2009 07:58:42 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pz0-f197.google.com (mail-pz0-f197.google.com [209.85.222.197]) by mx1.freebsd.org (Postfix) with ESMTP id 3B57D8FC39; Sat, 13 Jun 2009 07:58:42 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by pzk35 with SMTP id 35so1721288pzk.3 for ; Sat, 13 Jun 2009 00:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=2Dsax8gZtQcVXXRFVop7NLtJqNRkBwSlc2op1BxPVq4=; b=fTObudEuulNY2B+9hrGh1aHCIpnrFjTP446UGGH/NPxDrTsbiSF1AZgCInXhKiCnOI u9u/s+TNtStDcWYji+DCk3e8p44Yy+AhD6rSGZ0oLm/VdC5C7+g99eHcl34pDS/DqRU2 /S9/IqRcgFNylptnuh78NZHMugqRehLuqmmzE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=REgqW1bLB1RHv/uwca/9BaG1Jr/+SMmbjKi89tH1ItJu8fVlJ4rgXmLLJJKR6AiKep o7L2KR0yvEpLBRPySY7bCzcP/YAgQMUVIp8C3SPnEWC1RlTAuzoQBkSuenFbD9un7/bs pvy1XdhOzFqFznqU0DCMIo39/Ge0Sw3s+YyYs= Received: by 10.115.106.14 with SMTP id i14mr7631180wam.77.1244879921624; Sat, 13 Jun 2009 00:58:41 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ([114.111.62.249]) by mx.google.com with ESMTPS id m28sm2181937waf.37.2009.06.13.00.58.37 (version=SSLv3 cipher=RC4-MD5); Sat, 13 Jun 2009 00:58:38 -0700 (PDT) Received: by michelle.cdnetworks.co.kr (sSMTP sendmail emulation); Sat, 13 Jun 2009 17:01:36 +0900 From: Pyun YongHyeon Date: Sat, 13 Jun 2009 17:01:36 +0900 To: Michael Tuexen Message-ID: <20090613080136.GB76872@michelle.cdnetworks.co.kr> References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <20090612013406.GB72855@michelle.cdnetworks.co.kr> <20090612100900.M22887@maildrop.int.zabbadoz.net> <71535CB2-2784-4253-B67E-017FEAD57637@freebsd.org> <4A32F752.90003@cs.duke.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: FreeBSD net mailing list , Andrew Gallatin Subject: Re: Ethernet NIC drivers depending unconditionally on INET X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2009 07:58:42 -0000 On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: > On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: > > >Michael Tuexen wrote: > > > >> I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 > >> capabilities... Why would we want to enable IPv4 offloading and > >> not IPv6 or vice versa? > > > >I'd assume that some older hardware supports IPv4 offloads, but > >might not have support for IPv6 offloads. > Sure. But then the driver only provides the CSUM_ flags which > are appropriate. For example, a similar thing is already in the > igb driver: > > 1167 if (ifp->if_capenable & IFCAP_TXCSUM) { > 1168 ifp->if_hwassist |= (CSUM_TCP | CSUM_UDP); > 1169 #if __FreeBSD_version >= 800000 > 1170 if (adapter->hw.mac.type == e1000_82576) > 1171 ifp->if_hwassist |= CSUM_SCTP; > 1172 #endif > 1173 } That would disable all IPv4/IPv6 checksum offloading if administrator disable IFCAP_TXCSUM. If we have IFCAP_TXCSUM6/ IFCAP_RXCSUM6 users could choose best working one even if some part of driver/controller had checksum offload bugs. > > For FreeBSD 8 and a particular chip, SCTP checksum offloading > is supported. No need for a special IFCAP_TXCSUM. > > Best regards > Michael > > > > >Drew >