From nobody Fri Jan 19 18:15:06 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TGnpP6SnPz574VT; Fri, 19 Jan 2024 18:15:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TGnpP5r7Zz4Yv4; Fri, 19 Jan 2024 18:15:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705688109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mm0HbSTroYFeYmdXr21ppxegljJqwIE0ss4ZIqZyYik=; b=IqRW5OOsHtUjzZuAQ6aGxWGXf09V1SizwSzVq+Bg9jOMklEKmrtwDXWBZDB4Ishv8z8gOh G0TW+Ylc1oyGPfh1gPpfUTlCy7JOuMi6SzWJ9MD97s/Ha7tcDnF9k3FSNslLMoSISRbuIY UCJwDHsg0T2zEMDvG9l9gu59ZRsskA/YJFCgZ2DHNO/Ynh8mRLICSjQumPsULJfzuiZsNk sHihh0LLXvSYPgXRWu4vKWVS31JBfhzp/ZC0VpyftylvlYsLgFhhvVtS9Dkhrrs2wOKaYJ ZnkbH+6c8erL70BQNqTenMfRaIg+9RyVHxoHau61OO5W9ovWUCzjtkHgxTVzkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705688109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mm0HbSTroYFeYmdXr21ppxegljJqwIE0ss4ZIqZyYik=; b=cnvBgs5dy3SEcIBFr09ltV5pu59E5zrFsW8af6PWGf1AakrQJd80zMLOQtR2iny/s1FxIv StxHyqOVQZJ6NF+Px6GSY0xadDl4Vpv646kk411KNExn4e8Y3fyzXpjLZthF1bUk5Pxlib 9VHgpADFzUOtMjnTRrPBS9OqPKBUWcJTPhzngPETA+oFyYYsAFung0FdJdEbD1IpujZDpM c3OT0k1+dR7Fmft3eMl94iRRQSwGYWJpMLm73gSC+Gy10D72dfJt9+jZETMz732+SAEUQM HYh9QWQSuLhULejfMt9VJsggjSS7HEWPiM1Jbz4L4g/yDjCjXfnVtdzC0tJvRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705688109; a=rsa-sha256; cv=none; b=k+sqPbJjzeoLsj2MdDFVAzayfgnAWon0XbDyS+RTOHwR1dhfUjhe12kory6zAzuzE5SVWf CkaisfPjDoVCmz0zy7Zt7yd4kHlOp/7Nl+sFvQd3EpWEaLTySIHjnRP3SDTkWgdaUeqV9C ng4sVs9EX7Zh83YXFS3uSJfDQc1yDpWspzybdYK6uTI0xPyRrQIokI9PRqdVOLgq/A+G3c k3zHFx1n/S+6oV7GGTA2IUw1+4JsiXJJZ2hZ0mms1YXpVZGhwk7IQ5S4jAEVVI22mq6/GF JOQPP79iLKMmN3I8mJkT35xYP0BvhpAzA9sBGYGV/I3KEWPkBGKKfxhlaeA+6A== Received: from [IPV6:2601:644:9381:f410:f1f8:727d:5b89:e1a] (unknown [IPv6:2601:644:9381:f410:f1f8:727d:5b89:e1a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TGnpP1C2YzGQp; Fri, 19 Jan 2024 18:15:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 19 Jan 2024 10:15:06 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8bae22bbbe65 - main - fusefs: prefer new/delete over malloc/free Content-Language: en-US To: Alan Somers Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202401172250.40HMo4O9003460@gitrepo.freebsd.org> <8F36170D-9592-46D5-A275-12E24C3A13D8@gmail.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/19/24 7:38 AM, Alan Somers wrote: > On Fri, Jan 19, 2024 at 6:56 AM Alan Somers wrote: >> >> On Thu, Jan 18, 2024 at 10:32 PM Enji Cooper wrote: >>> >>> >>>> On Jan 17, 2024, at 2:50 PM, Alan Somers wrote: >>>> >>>> The branch main has been updated by asomers: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=8bae22bbbe6571da9259e0d43ffa8a56f4b3e171 >>>> >>>> commit 8bae22bbbe6571da9259e0d43ffa8a56f4b3e171 >>>> Author: Alan Somers >>>> AuthorDate: 2024-01-15 23:49:47 +0000 >>>> Commit: Alan Somers >>>> CommitDate: 2024-01-17 22:49:41 +0000 >>>> >>>> fusefs: prefer new/delete over malloc/free >>>> >>>> MFC after: 2 weeks >>>> Reviewed by: kib >>>> Differential Revision: https://reviews.freebsd.org/D43464 >>> >>> Why not use smart pointers instead? >>> -Enji >> >> Only because this stuff all evolved from C code. Smart pointers would >> certainly work. > > Actually, TBH it's because I'm not real great with C++. It's a > difficult language, and after 2016 I stopped even trying to improve my > C++ skills. Instead, I've been focusing on Rust. Even when I wrote > these tests in 2019, I strongly considered using Rust instead of C++. > In the end, the only thing that forced me to use C++ is because I > wanted them to live in the base system, rather than in ports. > > I still dream about the day when Rust is allowed in the base system. > If it were, then in addition to these tests, I would've converted > gstat to Rust (rather than add sysutils/gstat-rs to ports), added the > nfs-exporter (instead of putting it in net-mgmt/nfs-exporter), added a > ctl-exporter (which is impossible to do in ports, so I had to do that > one in C), and converted tools/regression/fsx in place (instead of > putting in devel/fsx-rs). Maybe a couple of other things, too. Like > ztop, or the geom-exporter that I have half-written. I've also been > tempted to rewrite zfsd in Rust. > > Alas, I sense that there is little appetite for bringing Rust into contrib. Brooks' opinion is that to support Rust in base we probably need to require always using an external toolchain as otherwise we would need to keep two copies of LLVM in base. -- John Baldwin