From owner-svn-src-all@FreeBSD.ORG Thu May 21 16:24:03 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A2B0106568E; Thu, 21 May 2009 16:24:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 683078FC1A; Thu, 21 May 2009 16:24:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 15AFA46B2C; Thu, 21 May 2009 12:24:03 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 0E7898A025; Thu, 21 May 2009 12:24:02 -0400 (EDT) From: John Baldwin To: Kostik Belousov Date: Thu, 21 May 2009 12:23:54 -0400 User-Agent: KMail/1.9.7 References: <3bbf2fe10905210629p46c7a204v6863aaba77354462@mail.gmail.com> <200905211211.00168.jhb@freebsd.org> <20090521161535.GQ1927@deviant.kiev.zoral.com.ua> In-Reply-To: <20090521161535.GQ1927@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905211223.55113.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 21 May 2009 12:24:02 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Scott Long , src-committers@freebsd.org, svn-src-all@freebsd.org, attilio@freebsd.org, rwatson@freebsd.org, svn-src-head@freebsd.org, "M. Warner Losh" Subject: Re: svn commit: r192535 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2009 16:24:04 -0000 On Thursday 21 May 2009 12:15:35 pm Kostik Belousov wrote: > On Thu, May 21, 2009 at 12:10:59PM -0400, John Baldwin wrote: > Another thing done inside destroy_dev is the call to the destructors > of the cdevpriv data, that never had any restrictions on the sleepable > context. > > We do have the KPI for the callers that cannot drop the locks and need > to do destroy_dev, destroy_dev_sched(9). With the caveat that you can't make any assumptions about other threads in your cdevsw routines being finished when it returns. If you have per-device data structures you need to free that are not handled by cdevpriv then you probably cannot safely free them. -- John Baldwin