From nobody Tue Jul 22 04:00:55 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bmNpw2Z3zz62N5H; Tue, 22 Jul 2025 04:00:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bmNpv4987z3cc7; Tue, 22 Jul 2025 04:00:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753156855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QTsJU1fhHmswzOnpvZ49WGUpSd8DVv2sbGTCMbwWy6A=; b=SRtjEVSYcyzFikdfi/pmp/nEmNgh5elLuUmsgyd7NshDuOwYmEkVFdKC/3QAoyi2ZpjDDf jqtSWzmR1pO0Uhlr8Jt7YthKf+4KQh5WkPbsAwjEsaF+FOKpD7KiY/Ch5eq4JIGe5h5QIN Pslimlh3HSbJJJ6FQtCR0z+pDobeCZZqWuIczZS/FbU0g5CZ1pDwMFiE5DMj8+L9ZxlXv9 vrA/5cPlkWSiMBC7SktFAy7LTNUUDY4/dNxEDIobPLwtICqzlyFkc1ovzj12di+9H6a+3T bFLbFmgbP5+I8tiTzjpfhCRksPSzbfko5kv7smAtmdPt1li4N7SNEaXC8q0nKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753156855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QTsJU1fhHmswzOnpvZ49WGUpSd8DVv2sbGTCMbwWy6A=; b=gUg1DzW3U323Do9FrugveDP2brPyac4vxc9Pqbpsjphb5dL5ralkBC1Q5rVOkuS7Ow0ETk eL2ElxE0OhnDF6WME/8M4PmTQf9dqOT8HBinEoosvM8rj0QqiLVE/EQhCOlBpt57J+RF71 tHG9aCI6kzI3VLhzNDoeCzSiDYjpputS1Z/g/M5HGday+LcZXrlYktQkj+xTjdMX+vs/ux V83v726xNzgQXYUOcijZtrDMtAixDrJtlFjpt8/IahmX0oeZ0+xO7fpcBdAfe4Pkxi6NzB l/PunfjaZ9qjZKylzhGuvSusJmU84WukBWA2jxRdk/TX+02fD8BCAL+zhgRg/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753156855; a=rsa-sha256; cv=none; b=Gel3YcuwnsUqDYSrzFM9tHojLc+IMOV6RrRDEpmROMQC41BjgK6C+61A6rggWLkuPLihDg 7cBIr7HsiM92Wp9toizlLK+vnDRx19aK242DRQ4PyRIr0IlxMdmmbEf95aN43y+IXCp9T7 O9Vb8d4ug7M9JIKuNBqNPbjL6AennMKpvwiVDNyTLtKNTpW83hPlH3mA4L82Nkiq457Tn7 0dZ2CRl0Vtmjf5TE9jAhoW0GtRzFU+n0JfpL7GNEDUHvTOeN5Fsf9AaRKlC+EZBzRX1Qwe HRfd3o64kDEONTFSuOHT6cDRZ/mkwNsHI4i1rQI7vUPFykj4yBsuSW2D7b2i8Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bmNpv3hGkz1QBS; Tue, 22 Jul 2025 04:00:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56M40tOe032555; Tue, 22 Jul 2025 04:00:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56M40t8R032552; Tue, 22 Jul 2025 04:00:55 GMT (envelope-from git) Date: Tue, 22 Jul 2025 04:00:55 GMT Message-Id: <202507220400.56M40t8R032552@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 7cbf41ef6022 - main - mmc_da: Queued CCBs need a priority other than CAM_PRIORITY_NONE List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7cbf41ef60227f2a4eaf01f600fc894ef0d50323 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=7cbf41ef60227f2a4eaf01f600fc894ef0d50323 commit 7cbf41ef60227f2a4eaf01f600fc894ef0d50323 Author: Warner Losh AuthorDate: 2025-07-22 03:38:55 +0000 Commit: Warner Losh CommitDate: 2025-07-22 04:00:53 +0000 mmc_da: Queued CCBs need a priority other than CAM_PRIORITY_NONE Queued CCBs usually are queued at CAM_PRIORITY_NORMAL, unless they are doing error recovery, or device enumeration of some kind. They should never be queued at CAM_PRIORITY_NONE, which should only be used for CCBs that are immediate. For sdda_start_init_task(), we allocate a ccb, initialize it then use it to talk to the SD/MMC card to query it, negotiate the speed and lane sizes, etc. Most of these commands are queued, so use the normal priority. Sponsored by: Netflix --- sys/cam/mmc/mmc_da.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c index 7f8bf3516804..322141a72707 100644 --- a/sys/cam/mmc/mmc_da.c +++ b/sys/cam/mmc/mmc_da.c @@ -1081,7 +1081,7 @@ sdda_start_init_task(void *context, int pending) CAM_DEBUG(periph->path, CAM_DEBUG_TRACE, ("sdda_start_init_task\n")); new_ccb = xpt_alloc_ccb(); xpt_setup_ccb(&new_ccb->ccb_h, periph->path, - CAM_PRIORITY_NONE); + CAM_PRIORITY_NORMAL); cam_periph_lock(periph); cam_periph_hold(periph, PRIBIO|PCATCH);