From owner-svn-ports-all@FreeBSD.ORG  Tue Apr 15 07:45:13 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E4EED53B;
 Tue, 15 Apr 2014 07:45:13 +0000 (UTC)
Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be
 [195.238.6.171])
 by mx1.freebsd.org (Postfix) with ESMTP id 07BE9178E;
 Tue, 15 Apr 2014 07:45:12 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AnUGAAbjTFNbsJaQ/2dsb2JhbABYgwY7S8M0gR8XdIIlAQEBBDocHgUQCw4GBAklDyoeBhOIAAEIzBsXjjAzB4Q4AQOYYYE3kQ+DMzs
Received: from 144.150-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.150.144])
 by relay.skynet.be with ESMTP; 15 Apr 2014 09:45:01 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s3F7j0t4001009;
 Tue, 15 Apr 2014 09:45:01 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Tue, 15 Apr 2014 09:45:00 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Boris Samorodov <bsam@FreeBSD.org>
Subject: Re: svn commit: r350154 - head/print/cups-base
Message-ID: <20140415094500.7ee3f9fb@kalimero.tijl.coosemans.org>
In-Reply-To: <201404041927.s34JRqvF052403@svn.freebsd.org>
References: <201404041927.s34JRqvF052403@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Apr 2014 07:45:14 -0000

On Fri, 4 Apr 2014 19:27:52 +0000 (UTC) Boris Samorodov wrote:
> Author: bsam
> Date: Fri Apr  4 19:27:51 2014
> New Revision: 350154
> URL: http://svnweb.freebsd.org/changeset/ports/350154
> QAT: https://qat.redports.org/buildarchive/r350154/
> 
> Log:
>   Use CFLAGS+=-fno-blocks to unbreak systems with default gcc compiler.
>   This is a band-aid that should be reworked for systems with blocks
>   and libdispatch support.
>   
>   Reported by:	Anton Shterenlikht <mexas@bris.ac.uk>
>   Discussed at:	freebsd-ports@
>   MFH:		2014Q2
> 
> Modified:
>   head/print/cups-base/Makefile
> 
> Modified: head/print/cups-base/Makefile
> ==============================================================================
> --- head/print/cups-base/Makefile	Fri Apr  4 19:27:02 2014	(r350153)
> +++ head/print/cups-base/Makefile	Fri Apr  4 19:27:51 2014	(r350154)
> @@ -299,4 +299,12 @@ post-install:
>  	${INSTALL_SCRIPT} ${WRKDIR}/ulpt-cupsd.sh ${STAGEDIR}${PREFIX}/sbin/
>  .endif
>  
> -.include <bsd.port.mk>
> +# This is just a band-aid to unbreak print/cups-client at systems with default gcc compiler,
> +# should be reworked to build with blocks and libdispatch support (via options).
> +#
> +.include <bsd.port.pre.mk>
> +.if defined(CUPS_CLIENT) && ${OPSYS} == "FreeBSD" && ${OSVERSION} > 1000000
> +CFLAGS+=	-fno-blocks
> +.endif
> +
> +.include <bsd.port.post.mk>

I think you need to patch /usr/local/include/cups/cups.h as well because
otherwise every port that uses it also needs this .if block.