From owner-cvs-all@FreeBSD.ORG  Tue Dec  6 01:10:22 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id E73F5106566B;
	Tue,  6 Dec 2011 01:10:22 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 8958C155556;
	Tue,  6 Dec 2011 01:10:20 +0000 (UTC)
Message-ID: <4EDD6B7C.4000801@FreeBSD.org>
Date: Mon, 05 Dec 2011 17:10:20 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:8.0) Gecko/20111110 Thunderbird/8.0
MIME-Version: 1.0
To: Michael Scheidell <scheidell@FreeBSD.org>
References: <201112032306.pB3N6l6V092069@repoman.freebsd.org>
In-Reply-To: <201112032306.pB3N6l6V092069@repoman.freebsd.org>
X-Enigmail-Version: undefined
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, "Alexey V. Panfilov" <ports@subnets.ru>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-mgmt/mrtg/files mrtg_daemon.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2011 01:10:23 -0000

A few suggestions for the rc.d file:

1. The options that you have _knobs for (such as _group, etc.) should
be in command_args, not in the default _flags option. I.e., there is no
reason to make them options twice.

2. The 2 separate lines:
: ${mrtg_daemon_pidfile="/var/run/mrtg/mrtg.pid"}
pidfile=${mrtg_daemon_pidfile}

Can be collapsed into one:
pidfile=${mrtg_daemon_pidfile="/var/run/mrtg/mrtg.pid"}

3. If mrtg_daemon_config is mandatory, it should be added to
required_files.

See
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for more information.


Doug


On 12/03/2011 15:06, Michael Scheidell wrote:
> scheidell    2011-12-03 23:06:47 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/mrtg/files  mrtg_daemon.in 
>   Log:
>   - Add shutdown keyword to rc script
>   
>   PR:             ports/162963  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=162963
>   Submitted by:   maintainer
>   Approved by:    maintainer,gabor(mentor)
>   Feature safe:   yes
>   
>   Revision  Changes    Path
>   1.3       +2 -1      ports/net-mgmt/mrtg/files/mrtg_daemon.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/mrtg/files/mrtg_daemon.in.diff?&r1=1.2&r2=1.3&f=h
> 



-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/