From owner-svn-src-all@FreeBSD.ORG Tue Jul 14 06:47:32 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AA8F106566B; Tue, 14 Jul 2009 06:47:32 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-yx0-f181.google.com (mail-yx0-f181.google.com [209.85.210.181]) by mx1.freebsd.org (Postfix) with ESMTP id B31638FC1E; Tue, 14 Jul 2009 06:47:31 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by yxe11 with SMTP id 11so5021964yxe.3 for ; Mon, 13 Jul 2009 23:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=m+Q5+odvfyXogsoMGLbn1mxi7bxtbWPqeKw+fqWg6Es=; b=K0YrToVGMFq30nk6oTYd2rS5w1TrDTxfmOjfZjkcBL5mk1rBpv/jHBEfdM9oZXuWrO dzrud9iGhWldEbFgY7ivIJst0JF7yRQbRtufZXhZVqs45+ULwreGbitK4AkPXoyFufpm OdSTfKGn+oP9tbX+xzL+Rc6q7/j5oD+0sueuI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=l18suG96QIK0tBva3MQmIYfjawZE24w/a2Y8mw3hULkyFyB5f2xueJ/irJgF4i/3JU Oz6Kd0pH3Tsr/ksl3s6lBO3aYy1o93zhHveGwhlLkaw/N8IV6sh5rHZq967TTalgoHVK ZZrwabtlfJuS0QEh5z9vnpuk6G0Qc06K2eSuI= MIME-Version: 1.0 Received: by 10.151.79.16 with SMTP id g16mr9468543ybl.313.1247552487304; Mon, 13 Jul 2009 23:21:27 -0700 (PDT) In-Reply-To: <200907121309.n6CD9iXj085206@svn.freebsd.org> References: <200907121309.n6CD9iXj085206@svn.freebsd.org> Date: Mon, 13 Jul 2009 23:21:27 -0700 Message-ID: From: Navdeep Parhar To: Ed Schouten Content-Type: multipart/mixed; boundary=00151750d95cd83019046ea47262 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195637 - head/lib/libc/stdio X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2009 06:47:32 -0000 --00151750d95cd83019046ea47262 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Sun, Jul 12, 2009 at 6:09 AM, Ed Schouten wrote: > Author: ed > Date: Sun Jul 12 13:09:43 2009 > New Revision: 195637 > URL: http://svn.freebsd.org/changeset/base/195637 > > Log: > Fix fwrite() to return 0 when size or nmemb are zero. Hello Ed, This breaks buildworld. This change itself compiles, but once the system's libc has this fwrite (say, after an installworld), buildworld on that system will fail. mklocale does not like fwrite returning 0. And who knows if there are other programs like this out there... .... mklocale -o am_ET.UTF-8.out /usr/src/share/mklocale/am_ET.UTF-8.src am_ET.UTF-8.out: Inappropriate ioctl for device *** Error code 1 Stop in /usr/src/share/mklocale. .... I've attached a patch to mklocale that will fix the problem. Regards, Navdeep --00151750d95cd83019046ea47262 Content-Type: application/octet-stream; name="mklocale.diff" Content-Disposition: attachment; filename="mklocale.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fx48emxj0 ZGlmZiAtciAzMzdhY2FhYjM2OGYgdXNyLmJpbi9ta2xvY2FsZS95YWNjLnkKLS0tIGEvdXNyLmJp bi9ta2xvY2FsZS95YWNjLnkJTW9uIEp1bCAxMyAyMjo0NDo0MyAyMDA5IC0wNzAwCisrKyBiL3Vz ci5iaW4vbWtsb2NhbGUveWFjYy55CU1vbiBKdWwgMTMgMjM6MTc6MTcgMjAwOSAtMDcwMApAQCAt NzMwLDggKzczMCw4IEBACiAgICAgLyoKICAgICAgKiBQQVJUIDY6IEFuZCBmaW5hbGx5IHRoZSB2 YXJpYWJsZSBkYXRhCiAgICAgICovCi0gICAgaWYgKGZ3cml0ZSh2YXJpYWJsZSwKLQkgICAgICAg bnRvaGwobmV3X2xvY2FsZS52YXJpYWJsZV9sZW4pLCAxLCBmcCkgIT0gMSkgeworICAgIGlmIChu ZXdfbG9jYWxlLnZhcmlhYmxlX2xlbiAmJgorCWZ3cml0ZSh2YXJpYWJsZSwgbnRvaGwobmV3X2xv Y2FsZS52YXJpYWJsZV9sZW4pLCAxLCBmcCkgIT0gMSkgewogCXBlcnJvcihsb2NhbGVfZmlsZSk7 CiAJZXhpdCgxKTsKICAgICB9Cg== --00151750d95cd83019046ea47262--