From owner-svn-ports-all@freebsd.org Sat May 25 06:36:37 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12A9415A3FEC; Sat, 25 May 2019 06:36:37 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3314F91CC1; Sat, 25 May 2019 06:36:36 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 9A1C633E06; Sat, 25 May 2019 02:36:34 -0400 (EDT) Received: from anthias (unknown [46.57.103.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id CB67633DF7; Sat, 25 May 2019 02:36:33 -0400 (EDT) Date: Sat, 25 May 2019 08:36:31 +0200 (CEST) From: Gerald Pfeifer To: Yuri cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494857 - in head/multimedia/webcamoid: . files In-Reply-To: <73df7274-1866-1f9f-3b4b-bc74eacff8e2@freebsd.org> Message-ID: References: <201903062230.x26MUo8W039525@repo.freebsd.org> <73df7274-1866-1f9f-3b4b-bc74eacff8e2@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 3314F91CC1 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-5.06 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.80)[ip: (-7.25), ipnet: 209.68.0.0/18(-0.94), asn: 7859(-0.77), country: US(-0.06)]; MX_GOOD(-0.01)[cached: mailwash29.pair.com]; NEURAL_HAM_SHORT(-0.95)[-0.950,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[33.103.57.46.zen.spamhaus.org : 127.0.0.11] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 May 2019 06:36:37 -0000 On Thu, 7 Mar 2019, Yuri wrote: >>> # Workaround for Bug#224137: devel/qt5-qmake: Doesn't use the right >>> compiler in case USE_GCC is selected >>> BINARY_ALIAS= g++=${CXX} >> ...this cannot be right any longer. Or at a minimum the comment >> referring to USE_GCC cannot be? > There are some architectures that use gcc as a default compiler, so > this line is relevant, but it could use if/endif block conditioned > on gcc being a compiler. Yes, but this port does not employ USE_GCC any more, so the comment is a bit confusuing (even if it's a reference). > I will add this, and related notes to the port. You haven't made such changes yet, have you? Gerald