From owner-freebsd-stable@FreeBSD.ORG Thu Jul 30 09:39:00 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD6C6106566C; Thu, 30 Jul 2009 09:39:00 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 889598FC15; Thu, 30 Jul 2009 09:39:00 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 3D23D46B06; Thu, 30 Jul 2009 05:39:00 -0400 (EDT) Date: Thu, 30 Jul 2009 10:39:00 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Matthew Fleming In-Reply-To: <06D5F9F6F655AD4C92E28B662F7F853E02F6F4BC@seaxch09.desktop.isilon.com> Message-ID: References: <06D5F9F6F655AD4C92E28B662F7F853E02F6F4BC@seaxch09.desktop.isilon.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: mlaier@FreeBSD.org, freebsd-stable@freebsd.org Subject: Re: Loading ng_socket at runtime? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2009 09:39:00 -0000 On Wed, 29 Jul 2009, Matthew Fleming wrote: > I'm doing a migration from releng/6.1 to stable/7, and one of the many new > things is that I get a warning when doing things with ng_socket that didn't > used to happen. > > WARNING: attempt to net_add_domain(netgraph) after domainfinalize() I've wondered about these warnings also, and am not sure they're justified -- any protocol loading after domainfinalize() should expect that timers are already started, etc, and loadable protocols are clearly desirable. > - ignore the warning (usually a bad idea...) Probably remove the warning. Some more synchronization is likely required in domain registration than is currently there -- on the other hand, it's probably not a big issue that it's missing as write operations on the domain list are conservative and extremely rare. I've CC'd Max Laier, who added the warnings -- perhaps he could lend some insight into the types of problems he anticipated. The main one I'm aware of is that mutating the domain list on a live system is risky because it's not well-synchronized -- however, adding domains should be pretty safe in practice. Robert