From owner-svn-ports-head@FreeBSD.ORG Fri May 17 22:30:42 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 80E71F68; Fri, 17 May 2013 22:30:42 +0000 (UTC) (envelope-from martymac@FreeBSD.org) Received: from lmtp.galacsys.net (webmail.galacsys.net [IPv6:2001:1b78:0:1:d918:51d7:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 4B68E1B2; Fri, 17 May 2013 22:30:42 +0000 (UTC) Received: from martymac.org (webmail.galacsys.net [217.24.81.215]) by lmtp.galacsys.net (Postfix) with ESMTP id BE3211FA5D07; Sat, 18 May 2013 00:30:39 +0200 (CEST) From: "Ganael LAPLANCHE" To: Alexey Dokuchaev , Ganael LAPLANCHE Subject: Re: svn commit: r318379 - in head/comms: . gr-osmosdr gr-osmosdr/files X-Openwebmail-Date: Sat, 18 May 2013 01:30:39 +0200 Message-Id: <20130517213537.M4362@FreeBSD.org> In-Reply-To: <20130517143856.GA68891@FreeBSD.org> References: <201305171310.r4HDABEk052378@svn.freebsd.org> <20130517143856.GA68891@FreeBSD.org> X-Mailer: Open WebMail 2.01 20030425 X-OriginatingIP: 88.163.147.236 (ganael.laplanche@martymac.org) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Date: Fri, 17 May 2013 22:30:42 +0000 (UTC) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2013 22:30:42 -0000 On Fri, 17 May 2013 14:38:56 +0000, Alexey Dokuchaev wrote Hi Alexey, Thanks for your mail. > Oh, is doxygen being used for documentation, or this port > actually really needs it for something functional? If it's > only for docs, can it be made OPTIONal? This is a mistake. The port does not need it for something functional, only for building docs, but doc build is not currently enabled. I'll double-check that and remove this un-needed dependency. > > +LIB_DEPENDS= gnuradio-core:${PORTSDIR}/comms/gnuradio \ > > + gnuradio-fcd:${PORTSDIR}/comms/gnuradio \ > > + gruel:${PORTSDIR}/comms/gnuradio \ > > + boost_system:${PORTSDIR}/devel/boost-libs \ > > + boost_thread:${PORTSDIR}/devel/boost-libs > > Doubling dependencies of comms/gnuradio and boost-libs looks a > bit silly; just picking one library per port would be sufficient. Technically, you are right ; but it has those advantages (and I can't see any disadvantage) : - it allows to keep track of what is *really* needed by the software and, thus, makes package maintenance easier - if in the future, a dependency does not provide anymore all of its libraries (e.g. because of a package split or software change), having explicit dependencies on every single needed library will prevent the software package from being installed. It will also help diagnose what is really missing when building the port. - if I had to choose only one library per dependency, why choosing that one instead of that other one ? That does not make much sense... I just don't want that package to be installed : I want it because it provides that (and that and that) I have checked the Porter's handbook and could not find advice on that... > We've been discouraging starting support-type descriptions > with 'Enable' word, but in this case it also helps to avoid > starting description with lower-case letter (presuming that > "rtl-sdr" spelled correctly), so maybe it's OK. OK, thanks. Best regards, -- Ganael LAPLANCHE http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac , http://www.FreeBSD.org